sets the default datatype in our vectorizers to float32 if not specified by users #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerhutcherson
force-pushed
the
feat/RAAE-517/default-float32
branch
from
0ea192b to
fb87288
Compare
rbs333
previously approved these changes
Jan 6, 2025
docs/user_guide/vectorizers_04.ipynb
Outdated
There was a problem hiding this comment.
Two small things on this
- this does have the warning which doesn't really matter but a heads up
2. is there a reason mistral is commented out? is there something we need to fix with that
There was a problem hiding this comment.
Yeah let's get rid of this warning. Good catch. 2 -- I think it had to do with stale API keys. @justin-cechmanek are those active again?
There was a problem hiding this comment.
Looks like the Mistral client is deprecated. I'll look into updating our vectorizer class for it.
There was a problem hiding this comment.
Nice. I see this one here: #255
After we get this warning removed from the notebook, I am happy to merge!
tylerhutcherson
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.