Improve RedisVL filter handling, docs, and examples #72
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 87.43% 87.51% +0.08%
==========================================
Files 17 17
Lines 899 937 +38
==========================================
+ Hits 786 820 +34
- Misses 113 117 +4
☔ View full report in Codecov by Sentry. |
tylerhutcherson
changed the title
tylerhutcherson
changed the title
There was a problem hiding this comment.
I'm approving, however, I think we should leave out the index updating (or maybe move somewhere other than getting started). I think it makes things seem more complicated and I think we want that to be the lowest bar to cross possible.
Other than that, I pushed up a few changes. Biggest thing is the change of _set_value. Essentially, I don't think it's necessary to treat anything except for tag differently. I've made a few tests for this as well and updated the hybrid query notebook.
| # TODO - enable async version of this | ||
| # check_redis_modules_exist(self._redis_conn) | ||
|
|
||
| if not self._fields: |
There was a problem hiding this comment.
This is the current behavior of the synchro version of the create method, and was just missing here
| @@ -499,6 +508,7 @@ def connect(self, url: Optional[str] = None, **kwargs): | |||
| ValueError: If no Redis URL is provided and REDIS_URL env var is not set. | |||
| """ | |||
| self._redis_conn = get_async_redis_connection(url, **kwargs) | |||
| return self | |||
| @@ -317,6 +318,7 @@ def connect(self, url: Optional[str] = None, **kwargs): | |||
| ValueError: If the REDIS_URL env var is not set and url is not provided. | |||
| """ | |||
| self._redis_conn = get_redis_connection(url, **kwargs) | |||
| return self | |||
There was a problem hiding this comment.
this feels odd given that then... it's a classmethod ... kindaof
Is this to make things more fluent?
There was a problem hiding this comment.
yes, it reduces the potential lines of code for a user by allowing index = SearchIndex.from_dict(...).connect(...)
Addresses #71 which highlights the need to support more edge case queries like "empty queries" or more sophisticated text LIKE query patterns.
overwrite=Falsecase.