Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test multiple versions of Python, Redis Stack, and hiredis option #73

Merged
merged 9 commits into from
Nov 1, 2023

Conversation

Spartee
Copy link
Contributor

@Spartee Spartee commented Nov 1, 2023

Building off of Chayims Pr in #62, This PR extends the test suite capability to more variations supported by Redis.

@Spartee Spartee added the CI/CD label Nov 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4e3de2d) 87.43% compared to head (8142bff) 87.43%.

❗ Current head 8142bff differs from pull request most recent head 359d24b. Consider uploading reports for the commit 359d24b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #73   +/-   ##
=======================================
  Coverage   87.43%   87.43%           
=======================================
  Files          17       17           
  Lines         899      899           
=======================================
  Hits          786      786           
  Misses        113      113           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tylerhutcherson
Copy link
Collaborator

Just pushed a small commit / fix that should handle the failing tests. LGTM thanks guys.

@tylerhutcherson tylerhutcherson changed the title Chayim test matrix Test multiple versions of Python, Redis Stack, and hiredis option Nov 1, 2023
@Spartee Spartee merged commit 76df66f into main Nov 1, 2023
18 checks passed
@Spartee Spartee deleted the chayim-test-matrix branch November 1, 2023 23:26
@Spartee Spartee mentioned this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants