-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IndexSchema refactor and async collapse #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start. Lots of thoughts on here. Would be good to sync on this and what you're doing with collapsing the interfaces.
Biggest theme here is reduction in code duplication, I think we can collapse
SchemaModel
FieldsModel
SchemaGenerator
into
Schema
Let me know what you think. Great start!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #85 +/- ##
==========================================
- Coverage 80.54% 78.64% -1.91%
==========================================
Files 19 21 +2
Lines 1203 1283 +80
==========================================
+ Hits 969 1009 +40
- Misses 234 274 +40 ☔ View full report in Codecov by Sentry. |
Introduce the `IndexSchema`. --------- Co-authored-by: Sam Partee <sam.partee@redis.com>
This PR introduces a new user space class,
IndexSchema
. This effort to refactor the index schema is key for us to be able to enable "wrappability" and extensibility of RedisVL with other integration efforts (i.e. LangChain), and also improve the UX of working with the tool overall.A few changes:
AsyncSearchIndex
class here.Adding link to current notes on the schema spec: https://docs.google.com/document/d/1vkShf9PoQd1FnjYa2PpKhcgk8FW9WZGi_KpCuoDtvEY/edit?usp=sharing