Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cleanup routines for underlying http transport #44

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

andrewstucki
Copy link
Contributor

This PR does a couple of things:

  1. It limits the amount of connections we actually allow the undelrying http.Transport to initialize in the rpadmin client and sets some sane defaults based for idle connection timeouts based off of http.DefaultTransport
  2. It introduces a Close method that flushes all idle connections in the connection pool. This allows us to manually close all pooled connections when a client is no longer needed.

@RafalKorepta RafalKorepta merged commit 05ac588 into main Dec 19, 2024
2 checks passed
@RafalKorepta RafalKorepta deleted the transport-pooling-cleanup branch December 19, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants