redpanda: assert backwards compat guarantees #1236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisseto
force-pushed
the
chris/fuzz-redpanda
branch
from
4d6396f to
161aa66
Compare
charts/redpanda/values.go
Outdated
| Enabled *bool `json:"enabled" jsonschema:"required"` | ||
| Certs *TLSCertMap `json:"certs"` | ||
| Enabled *bool `json:"enabled" jsonschema:"required"` | ||
| Certs TLSCertMap `json:"certs"` |
There was a problem hiding this comment.
If this is not a pointer, should the jsonschema be set to required?
There was a problem hiding this comment.
Nice catch! Fixed.
chrisseto
force-pushed
the
chris/fuzz-redpanda
branch
2 times, most recently
from
85a9e82 to
255f730
Compare
chrisseto
force-pushed
the
chris/fuzz-redpanda
branch
2 times, most recently
from
6c07a96 to
fa56782
Compare
This commit utilizes `valuesutil.Generate` to assert the backwards compatibility guarantees of the redpanda chart's values.schema.json across all minor versions start with the 5.6.x series. The guarantee is both documented and enforced by `TestSchemaBackwardCompat` test.
chrisseto
force-pushed
the
chris/fuzz-redpanda
branch
from
fa56782 to
ce09ab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
161aa66 redpanda: assert backwards compat guarantees
This commit utilizes
valuesutil.Generateto assert the backwardscompatibility guarantees of the redpanda chart's values.schema.json
across all minor versions start with the 5.6.x series.
The guarantee is both documented and enforced by
TestSchemaBackwardCompattest.