Skip to content

Commit

Permalink
operator v1: add additionalCommandlineArguments flag
Browse files Browse the repository at this point in the history
additionalCommandlineArguments needs to be per-nodepool, because it can
have different values. concrete example is the --cpuset flag, which
differs.
  • Loading branch information
birdayz committed Oct 29, 2024
1 parent 87317b4 commit 55d637a
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 0 deletions.
4 changes: 4 additions & 0 deletions operator/api/vectorized/v1alpha1/cluster_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,10 @@ type NodePoolSpec struct {
// Cache directory that will be mounted for Cloud Storage.
// +required
CloudCacheStorage StorageSpec `json:"cloudCacheStorage"`
// Additional command line arguments that we pass to the redpanda binary
// These are applied last and will override any other command line arguments that may be defined,
// including the ones added when setting `DeveloperMode` to `true`.
AdditionalCommandlineArguments map[string]string `json:"additionalCommandlineArguments,omitempty"`
}

// RestartConfig contains strategies to configure how the cluster behaves when restarting, because of upgrades
Expand Down
7 changes: 7 additions & 0 deletions operator/api/vectorized/v1alpha1/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,14 @@ spec:
Replicas, so they can be controlled independently
Resources, because this is tied strongly to the actual machine shape backing the NodePool.
properties:
additionalCommandlineArguments:
additionalProperties:
type: string
description: |-
Additional command line arguments that we pass to the redpanda binary
These are applied last and will override any other command line arguments that may be defined,
including the ones added when setting `DeveloperMode` to `true`.
type: object
cloudCacheStorage:
description: Cache directory that will be mounted for Cloud
Storage.
Expand Down

0 comments on commit 55d637a

Please sign in to comment.