Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart-redpanda: cut release v5.9.19 #393

Merged
merged 4 commits into from
Jan 19, 2025
Merged

Conversation

chrisseto
Copy link
Contributor

This commit cuts release v5.9.19 of the redpanda chart and fixes TestChartYAMLVersions to work with changie and the new repo structure.

@chrisseto
Copy link
Contributor Author

This will need to be synced back to the helm-charts repository to officially be released.

@chrisseto chrisseto force-pushed the chris/p/chart-redpanda-5.9.19 branch from ed12c75 to 0760379 Compare January 14, 2025 21:34
@RafalKorepta RafalKorepta force-pushed the chris/p/chart-redpanda-5.9.19 branch 2 times, most recently from bae1edb to 28e5e3d Compare January 15, 2025 12:36
@RafalKorepta
Copy link
Contributor

I found the problem in unit test. The unreleased version 5.9.19 is not available in official helm repository index (github.com/redpanda-data/helm-charts is not synced yet).

"level"=0 "msg"="HelmChart 'testenv-25w8t/testenv-25w8t-rp-fv2vfj' is not ready: invalid chart reference: failed to get chart version for remote reference: no 'redpanda' chart with version matching '5.9.19' found"

@RafalKorepta
Copy link
Contributor

chartVersion := rp.Spec.ChartRef.ChartVersion
desiredChartVersion := redpanda.Chart.Metadata().Version
if !(chartVersion == "" || chartVersion == desiredChartVersion) {

@chrisseto chrisseto force-pushed the chris/p/chart-redpanda-5.9.19 branch 2 times, most recently from 82ac982 to 2abe951 Compare January 15, 2025 20:14
@RafalKorepta RafalKorepta force-pushed the chris/p/chart-redpanda-5.9.19 branch 6 times, most recently from e0cd2c0 to 2aff951 Compare January 17, 2025 18:01
@chrisseto chrisseto force-pushed the chris/p/chart-redpanda-5.9.19 branch from 2aff951 to 35fdf22 Compare January 17, 2025 20:20
This commit cuts release v5.9.19 of the redpanda chart, fixes
`TestChartYAMLVersions` to work with changie and the new repo structure, and
disables operator tests that depend on the redpanda chart version matching the
most recently published redpanda chart as there is currently a manual step
required to finalize the release.
@chrisseto chrisseto force-pushed the chris/p/chart-redpanda-5.9.19 branch 5 times, most recently from 0c8a7b9 to 4a4c15f Compare January 17, 2025 21:04
@chrisseto chrisseto force-pushed the chris/p/chart-redpanda-5.9.19 branch from 4a4c15f to 0eaf6ca Compare January 17, 2025 21:17
This commit pins the charts module version to the commit closest to
v5.9.18 of the redpanda helm chart. There is no exact commit to pin to
due to the monorepo migration.

Additional this commit includes a small fix to the redpanda controller
that prevents the status updated from failing due to unexpected usage of
optimistic locking.
- task: :test:integration
vars:
GO_TEST_RUNNER: gotestsum
CLI_ARGS: --junitfile=integration-tests.xml -- {{.CLI_ARGS}}
GO_TEST_RUNNER: gotestsum --raw-command --junitfile=integration-tests-%.xml -- go test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: the % character might be hard to understand when I would look at this line in month time. A comment, that explain xargs usage in test:integration could help (at least me).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call out. I can push up some notes. It's very hacky 🙈

Comment on lines +30 to +33
licenseupdater:
dir: licenseupdater
cmds:
- go build -o ../.build/licenseupdater .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the update-licenses target has the following command

go run -C licenseupdater ./... -config ../.licenseupdater.yaml

then I don't understand why licenseupdater needs to be build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think this is just due to a bad merge resolution on my behalf. Sorry! This can be removed or we can update the go run. No strong feelings.

@RafalKorepta
Copy link
Contributor

The integration tests would be fixed in next commits. This PR needs to be merged in order to release operator.

@RafalKorepta RafalKorepta merged commit 2734dfd into main Jan 19, 2025
7 of 8 checks passed
@chrisseto chrisseto deleted the chris/p/chart-redpanda-5.9.19 branch January 21, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants