-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chart-redpanda: cut release v5.9.19 #393
Conversation
This will need to be synced back to the helm-charts repository to officially be released. |
ed12c75
to
0760379
Compare
bae1edb
to
28e5e3d
Compare
I found the problem in unit test. The unreleased version 5.9.19 is not available in official helm repository index (
|
redpanda-operator/operator/internal/controller/redpanda/redpanda_controller.go Lines 336 to 339 in 8a17e7c
|
82ac982
to
2abe951
Compare
e0cd2c0
to
2aff951
Compare
2aff951
to
35fdf22
Compare
This commit cuts release v5.9.19 of the redpanda chart, fixes `TestChartYAMLVersions` to work with changie and the new repo structure, and disables operator tests that depend on the redpanda chart version matching the most recently published redpanda chart as there is currently a manual step required to finalize the release.
0c8a7b9
to
4a4c15f
Compare
4a4c15f
to
0eaf6ca
Compare
This commit pins the charts module version to the commit closest to v5.9.18 of the redpanda helm chart. There is no exact commit to pin to due to the monorepo migration. Additional this commit includes a small fix to the redpanda controller that prevents the status updated from failing due to unexpected usage of optimistic locking.
- task: :test:integration | ||
vars: | ||
GO_TEST_RUNNER: gotestsum | ||
CLI_ARGS: --junitfile=integration-tests.xml -- {{.CLI_ARGS}} | ||
GO_TEST_RUNNER: gotestsum --raw-command --junitfile=integration-tests-%.xml -- go test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: the %
character might be hard to understand when I would look at this line in month time. A comment, that explain xargs
usage in test:integration
could help (at least me).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call out. I can push up some notes. It's very hacky 🙈
licenseupdater: | ||
dir: licenseupdater | ||
cmds: | ||
- go build -o ../.build/licenseupdater . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the update-licenses
target has the following command
go run -C licenseupdater ./... -config ../.licenseupdater.yaml
then I don't understand why licenseupdater
needs to be build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think this is just due to a bad merge resolution on my behalf. Sorry! This can be removed or we can update the go run
. No strong feelings.
The integration tests would be fixed in next commits. This PR needs to be merged in order to release operator. |
This commit cuts release v5.9.19 of the redpanda chart and fixes
TestChartYAMLVersions
to work with changie and the new repo structure.