feat(cells): Optimize default afterQuery by avoiding memcopy #11758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just stumbled over this. Not sure how much the browser engines are optimized for this kinds of operations nowadays, but at the end of the day it cannot JIT it completely away and i guess it would still need to create a full copy in memory. Some of the "literature" seems to confirm this at least as best practice consideration:
At the end of the day one may consider this a neglectable micro-optimization, but as the redwood cell is the "work horse" for data piped to the frontend (which may potentially include large amounts of data) this may be worth it – at least it won't hurt 😉