fix(router): Correctly infer generic for <Set>
#11768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
added
release:fix
|
Actually, this change introduced this bug for me:
… and also it broke TS hinting for required props of the first component in a wrap-array. What exactly did it fix though? 😉 |
|
In hindsight, and with the knowledge I've gained since merging this PR I don't think this change makes much sense in isolation. The problem with |
Tobbe
changed the title
<Set>
Tobbe
changed the title
<Set>
Tobbe
changed the title
<Set>
Tobbe
added a commit
to Tobbe/redwood
that referenced
this pull request
Jan 17, 2025
This reverts commit 8e1644a.
Tobbe
added a commit
that referenced
this pull request
Jan 17, 2025
This was referenced Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #11756, so they have to be released together