Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Fix Cell test generation for list cells #11779

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Dec 14, 2024

Fixes a regression introduced in #11749

Only tests for cells that fetches a unique item should have an id field, not cells that fetches all the things

@Tobbe Tobbe added the release:fix This PR is a fix label Dec 14, 2024
@Tobbe Tobbe added this to the next-release-patch milestone Dec 14, 2024
@Tobbe Tobbe added the changesets-ok Override the changesets check label Dec 14, 2024
@Tobbe Tobbe enabled auto-merge (squash) December 14, 2024 10:50
@Tobbe Tobbe merged commit aa0a44e into redwoodjs:main Dec 14, 2024
54 of 63 checks passed
@Tobbe Tobbe deleted the tobbe-no-id-in-list-cell-test branch December 14, 2024 11:42
@Philzen
Copy link
Contributor

Philzen commented Dec 14, 2024

Awesome! Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changesets-ok Override the changesets check release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants