Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev server] Remove extraneous whitespace in dev server's nodemon command #11875

Closed
wants to merge 2 commits into from
Closed

[dev server] Remove extraneous whitespace in dev server's nodemon command #11875

wants to merge 2 commits into from

Conversation

Philzen
Copy link
Contributor

@Philzen Philzen commented Jan 2, 2025 •
edited
Loading

Just a little thing that had been bugging my eye ever since when stopping the dev server:

grafik

With this PR applied it looks proper:

grafik

@Tobbe Tobbe mentioned this pull request Jan 6, 2025
Merged
@Tobbe
Copy link
Member

Tobbe commented Jan 6, 2025

Sorry @Philzen, I prefer the code the way it was originally. I agree the output looks better after your change, but I think the code is easier to understand with the indentation in place.
I went with an alternative implementation: #11880

@Tobbe Tobbe closed this Jan 6, 2025
Tobbe added a commit that referenced this pull request Jan 6, 2025
@Tobbe
fix(dev): Remove redundant whitespace in cli output (#11880)
52bc232 
Alternative implementation of
#11875

Remove redundant whitespace in cli cmd output

Before: 
<img width="982" alt="image"
src="https://github.com/user-attachments/assets/3a4c644d-bab7-4ea7-8196-57f71b670a5a"
/>

After:
<img width="986" alt="image"
src="https://github.com/user-attachments/assets/6478088e-6aae-4ff4-971d-b1f963d58469"
/>
@Philzen Philzen deleted the bugfix/remove-extraneous-whitespace-in-nodemon-development-cmd branch January 6, 2025 09:14
Tobbe added a commit that referenced this pull request Jan 16, 2025
@Tobbe
fix(dev): Remove redundant whitespace in cli output (#11880)
f18faac 
Alternative implementation of
#11875

Remove redundant whitespace in cli cmd output

Before: 
<img width="982" alt="image"
src="https://github.com/user-attachments/assets/3a4c644d-bab7-4ea7-8196-57f71b670a5a"
/>

After:
<img width="986" alt="image"
src="https://github.com/user-attachments/assets/6478088e-6aae-4ff4-971d-b1f963d58469"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Philzen @Tobbe