Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to @typescript-eslint version that supports TypeScript 5.6.2 #11878

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Update to @typescript-eslint version that supports TypeScript 5.6.2 #11878

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78a3143
Fix TS version warning by updating @typescript-eslint/parser to v8.19.1
Philzen Jan 6, 2025
0c0228e
Synchronize @typescript/eslint-plugin, /rule-tester & /utils versions
Philzen Jan 6, 2025
6914b03
Fix @typescript-eslint/await-thenable rule violations
Philzen Jan 6, 2025
959138e
changeset
Tobbe Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changesets/11878.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- Update to @typescript-eslint version that supports TypeScript 5.6.2 (#11878) by @Philzen

Fix TS version warning when running `yarn rw lint`
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@
"@types/jscodeshift": "0.12.0",
"@types/ncp": "2.0.8",
"@types/prompts": "2.4.9",
"@typescript-eslint/eslint-plugin": "8.5.0",
"@typescript-eslint/parser": "8.5.0",
"@typescript-eslint/eslint-plugin": "8.19.1",
"@typescript-eslint/parser": "8.19.1",
"@yarnpkg/types": "4.0.0",
"all-contributors-cli": "6.26.1",
"babel-jest": "^29.7.0",
Expand Down
4 changes: 2 additions & 2 deletions packages/eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@
"@redwoodjs/eslint-plugin": "workspace:*",
"@redwoodjs/internal": "workspace:*",
"@redwoodjs/project-config": "workspace:*",
"@typescript-eslint/eslint-plugin": "8.5.0",
"@typescript-eslint/parser": "8.5.0",
"@typescript-eslint/eslint-plugin": "8.19.1",
"@typescript-eslint/parser": "8.19.1",
"eslint": "8.57.1",
"eslint-config-prettier": "9.1.0",
"eslint-import-resolver-babel-module": "5.3.2",
Expand Down
6 changes: 3 additions & 3 deletions packages/eslint-plugin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@
"test:watch": "vitest watch"
},
"dependencies": {
"@typescript-eslint/utils": "8.5.0",
"@typescript-eslint/utils": "8.19.1",
"eslint": "8.57.1"
},
"devDependencies": {
"@redwoodjs/framework-tools": "workspace:*",
"@types/eslint": "8.56.12",
"@types/estree": "1.0.6",
"@typescript-eslint/parser": "8.5.0",
"@typescript-eslint/rule-tester": "8.5.0",
"@typescript-eslint/parser": "8.19.1",
"@typescript-eslint/rule-tester": "8.19.1",
"tsx": "4.19.2",
"typescript": "5.6.2",
"vitest": "2.0.5"
Expand Down
2 changes: 1 addition & 1 deletion packages/storage/src/createSavers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export const createUploadSavers = <MNames extends ModelNames = ModelNames>(

savers[saverKey] = async (data, overrideSaveOptions) => {
const updatedFields = {} as Record<string, string>
for await (const field of currentModelUploadFields) {
for (const field of currentModelUploadFields) {
if (data[field]) {
const file = data[field]

Expand Down
6 changes: 3 additions & 3 deletions packages/storage/src/prismaExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export const createUploadsExtension = <MNames extends ModelNames = ModelNames>(
const createDatas = args.data as []

// If the create fails, we need to delete the uploaded files
for await (const createData of createDatas) {
for (const createData of createDatas) {
await removeUploadedFiles(uploadFields, createData)
}

Expand Down Expand Up @@ -258,7 +258,7 @@ export const createUploadsExtension = <MNames extends ModelNames = ModelNames>(
return async () => {
const base64UploadFields: Record<keyof typeof needs, string> = {}

for await (const field of uploadFields) {
for (const field of uploadFields) {
base64UploadFields[field] = await fileToDataUri(
modelData[field] as string,
storageAdapter,
Expand Down Expand Up @@ -329,7 +329,7 @@ export const createUploadsExtension = <MNames extends ModelNames = ModelNames>(
return
}

for await (const field of fieldsToDelete) {
for (const field of fieldsToDelete) {
const uploadLocation = data?.[field]
if (uploadLocation) {
try {
Expand Down
171 changes: 87 additions & 84 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8331,8 +8331,8 @@ __metadata:
"@redwoodjs/eslint-plugin": "workspace:*"
"@redwoodjs/internal": "workspace:*"
"@redwoodjs/project-config": "workspace:*"
"@typescript-eslint/eslint-plugin": "npm:8.5.0"
"@typescript-eslint/parser": "npm:8.5.0"
"@typescript-eslint/eslint-plugin": "npm:8.19.1"
"@typescript-eslint/parser": "npm:8.19.1"
eslint: "npm:8.57.1"
eslint-config-prettier: "npm:9.1.0"
eslint-import-resolver-babel-module: "npm:5.3.2"
Expand All @@ -8355,9 +8355,9 @@ __metadata:
"@redwoodjs/framework-tools": "workspace:*"
"@types/eslint": "npm:8.56.12"
"@types/estree": "npm:1.0.6"
"@typescript-eslint/parser": "npm:8.5.0"
"@typescript-eslint/rule-tester": "npm:8.5.0"
"@typescript-eslint/utils": "npm:8.5.0"
"@typescript-eslint/parser": "npm:8.19.1"
"@typescript-eslint/rule-tester": "npm:8.19.1"
"@typescript-eslint/utils": "npm:8.19.1"
eslint: "npm:8.57.1"
tsx: "npm:4.19.2"
typescript: "npm:5.6.2"
Expand Down Expand Up @@ -11586,135 +11586,131 @@ __metadata:
languageName: node
linkType: hard

"@typescript-eslint/eslint-plugin@npm:8.5.0":
version: 8.5.0
resolution: "@typescript-eslint/eslint-plugin@npm:8.5.0"
"@typescript-eslint/eslint-plugin@npm:8.19.1":
version: 8.19.1
resolution: "@typescript-eslint/eslint-plugin@npm:8.19.1"
dependencies:
"@eslint-community/regexpp": "npm:^4.10.0"
"@typescript-eslint/scope-manager": "npm:8.5.0"
"@typescript-eslint/type-utils": "npm:8.5.0"
"@typescript-eslint/utils": "npm:8.5.0"
"@typescript-eslint/visitor-keys": "npm:8.5.0"
"@typescript-eslint/scope-manager": "npm:8.19.1"
"@typescript-eslint/type-utils": "npm:8.19.1"
"@typescript-eslint/utils": "npm:8.19.1"
"@typescript-eslint/visitor-keys": "npm:8.19.1"
graphemer: "npm:^1.4.0"
ignore: "npm:^5.3.1"
natural-compare: "npm:^1.4.0"
ts-api-utils: "npm:^1.3.0"
ts-api-utils: "npm:^2.0.0"
peerDependencies:
"@typescript-eslint/parser": ^8.0.0 || ^8.0.0-alpha.0
eslint: ^8.57.0 || ^9.0.0
peerDependenciesMeta:
typescript:
optional: true
checksum: 10c0/69ae7067e03d2d8d442e69d668235bdafd63b07229d0be27025eaad8aa468b5af8ac54627021e0e3a060df04ed1c39d1327a0b11469ac72405b52b74a79f402b
typescript: ">=4.8.4 <5.8.0"
checksum: 10c0/993784b04533b13c3f3919c793cfc3a369fa61692e1a2d72de6fba27df247c275d852cdcbc4e393c310b73fce8d34d210a9b632b66f4d761a1a3b4781f8fa93f
languageName: node
linkType: hard

"@typescript-eslint/parser@npm:8.5.0":
version: 8.5.0
resolution: "@typescript-eslint/parser@npm:8.5.0"
"@typescript-eslint/parser@npm:8.19.1":
version: 8.19.1
resolution: "@typescript-eslint/parser@npm:8.19.1"
dependencies:
"@typescript-eslint/scope-manager": "npm:8.5.0"
"@typescript-eslint/types": "npm:8.5.0"
"@typescript-eslint/typescript-estree": "npm:8.5.0"
"@typescript-eslint/visitor-keys": "npm:8.5.0"
"@typescript-eslint/scope-manager": "npm:8.19.1"
"@typescript-eslint/types": "npm:8.19.1"
"@typescript-eslint/typescript-estree": "npm:8.19.1"
"@typescript-eslint/visitor-keys": "npm:8.19.1"
debug: "npm:^4.3.4"
peerDependencies:
eslint: ^8.57.0 || ^9.0.0
peerDependenciesMeta:
typescript:
optional: true
checksum: 10c0/509fdd605b86c7d025928f20e1035712c2fc268c34b1af84248ed0b53d699034f19caf98e085c5c758d3025e29939dd12eea427c72cae9e5ea79274364851f0a
typescript: ">=4.8.4 <5.8.0"
checksum: 10c0/1afbd2d0a25f439943bdc94637417429574eb3889a2a1ce24bd425721713aca213808a975bb518a6616171783bc04fa973167f05fc6a96cfd88c1d1666077ad4
languageName: node
linkType: hard

"@typescript-eslint/rule-tester@npm:8.5.0":
version: 8.5.0
resolution: "@typescript-eslint/rule-tester@npm:8.5.0"
"@typescript-eslint/rule-tester@npm:8.19.1":
version: 8.19.1
resolution: "@typescript-eslint/rule-tester@npm:8.19.1"
dependencies:
"@typescript-eslint/typescript-estree": "npm:8.5.0"
"@typescript-eslint/utils": "npm:8.5.0"
"@typescript-eslint/typescript-estree": "npm:8.19.1"
"@typescript-eslint/utils": "npm:8.19.1"
ajv: "npm:^6.12.6"
json-stable-stringify-without-jsonify: "npm:^1.0.1"
lodash.merge: "npm:4.6.2"
semver: "npm:^7.6.0"
peerDependencies:
eslint: ^8.57.0 || ^9.0.0
checksum: 10c0/decb1186abd37b8a5fd62b8b7d77673dc591b9786fb696042e4afa4634ae5e8ae098f52e3ca2d7ce7d9c2ad76897f2a45afeaaf11fdd697747a01e0f51c760a6
checksum: 10c0/eb8d3ff4113aca41aa3df1bf9df67828e03c9aff6beaae522f374408786691f177b66b03eef55f6907fe50325eea3d2f7e215acfd91de3f34edd0b6cd9e94f91
languageName: node
linkType: hard

"@typescript-eslint/scope-manager@npm:8.5.0":
version: 8.5.0
resolution: "@typescript-eslint/scope-manager@npm:8.5.0"
"@typescript-eslint/scope-manager@npm:8.19.1":
version: 8.19.1
resolution: "@typescript-eslint/scope-manager@npm:8.19.1"
dependencies:
"@typescript-eslint/types": "npm:8.5.0"
"@typescript-eslint/visitor-keys": "npm:8.5.0"
checksum: 10c0/868602f9324a6e15fcae017acd3b0832e9f2c8c8cd315667df37c2e7c765cda5fba7c4bede931f32cc04819ba97cf74a5fddb085c6f1c7993f1fb085ba126422
"@typescript-eslint/types": "npm:8.19.1"
"@typescript-eslint/visitor-keys": "npm:8.19.1"
checksum: 10c0/7dca0c28ad27a0c7e26499e0f584f98efdcf34087f46aadc661b36c310484b90655e83818bafd249b5a28c7094a69c54d553f6cd403869bf134f95a9148733f5
languageName: node
linkType: hard

"@typescript-eslint/type-utils@npm:8.5.0":
version: 8.5.0
resolution: "@typescript-eslint/type-utils@npm:8.5.0"
"@typescript-eslint/type-utils@npm:8.19.1":
version: 8.19.1
resolution: "@typescript-eslint/type-utils@npm:8.19.1"
dependencies:
"@typescript-eslint/typescript-estree": "npm:8.5.0"
"@typescript-eslint/utils": "npm:8.5.0"
"@typescript-eslint/typescript-estree": "npm:8.19.1"
"@typescript-eslint/utils": "npm:8.19.1"
debug: "npm:^4.3.4"
ts-api-utils: "npm:^1.3.0"
peerDependenciesMeta:
typescript:
optional: true
checksum: 10c0/675d3e41f938d16e9268fd33764a4e16b12a4a9817e61d5e2508a07fe6783c69ce9d05facc61822b5647c71d767929618ed37b8b93f423f7c2ccb62cfeb4343b
ts-api-utils: "npm:^2.0.0"
peerDependencies:
eslint: ^8.57.0 || ^9.0.0
typescript: ">=4.8.4 <5.8.0"
checksum: 10c0/757592b515beec58c079c605aa648ba94d985ae48ba40460034e849c7bc2b603b1da6113e59688e284608c9d5ccaa27adf0a14fb032cb1782200c6acae51ddd2
languageName: node
linkType: hard

"@typescript-eslint/types@npm:8.5.0":
version: 8.5.0
resolution: "@typescript-eslint/types@npm:8.5.0"
checksum: 10c0/f0b666b5c001b9779bfd9e4c7d031843d07264429d5bcf5d636f26f96cd5d949a33f5d6a645b8d74b93daf565a468476a6a4935dd7135a200250fb03acbe4988
"@typescript-eslint/types@npm:8.19.1":
version: 8.19.1
resolution: "@typescript-eslint/types@npm:8.19.1"
checksum: 10c0/e907bf096d5ed7a812a1e537a98dd881ab5d2d47e072225bfffaa218c1433115a148b27a15744db8374b46dac721617c6d13a1da255fdeb369cf193416533f6e
languageName: node
linkType: hard

"@typescript-eslint/typescript-estree@npm:8.5.0":
version: 8.5.0
resolution: "@typescript-eslint/typescript-estree@npm:8.5.0"
"@typescript-eslint/typescript-estree@npm:8.19.1":
version: 8.19.1
resolution: "@typescript-eslint/typescript-estree@npm:8.19.1"
dependencies:
"@typescript-eslint/types": "npm:8.5.0"
"@typescript-eslint/visitor-keys": "npm:8.5.0"
"@typescript-eslint/types": "npm:8.19.1"
"@typescript-eslint/visitor-keys": "npm:8.19.1"
debug: "npm:^4.3.4"
fast-glob: "npm:^3.3.2"
is-glob: "npm:^4.0.3"
minimatch: "npm:^9.0.4"
semver: "npm:^7.6.0"
ts-api-utils: "npm:^1.3.0"
peerDependenciesMeta:
typescript:
optional: true
checksum: 10c0/f62f03d0c5dc57b2b54dbe1cbd027966f774f241279655f46c64145abb54b765176a0cd40447583ba56ada306181da9a82e39b777c78128e105e4ea98c609350
ts-api-utils: "npm:^2.0.0"
peerDependencies:
typescript: ">=4.8.4 <5.8.0"
checksum: 10c0/549d9d565a58a25fc8397a555506f2e8d29a740f5b6ed9105479e22de5aab89d9d535959034a8e9d4115adb435de09ee6987d28e8922052eea577842ddce1a7a
languageName: node
linkType: hard

"@typescript-eslint/utils@npm:8.5.0":
version: 8.5.0
resolution: "@typescript-eslint/utils@npm:8.5.0"
"@typescript-eslint/utils@npm:8.19.1":
version: 8.19.1
resolution: "@typescript-eslint/utils@npm:8.19.1"
dependencies:
"@eslint-community/eslint-utils": "npm:^4.4.0"
"@typescript-eslint/scope-manager": "npm:8.5.0"
"@typescript-eslint/types": "npm:8.5.0"
"@typescript-eslint/typescript-estree": "npm:8.5.0"
"@typescript-eslint/scope-manager": "npm:8.19.1"
"@typescript-eslint/types": "npm:8.19.1"
"@typescript-eslint/typescript-estree": "npm:8.19.1"
peerDependencies:
eslint: ^8.57.0 || ^9.0.0
checksum: 10c0/0cb0bfdaf0da79d13c0d0379478eb14b5825d235873bc7181e70c4f6297fa1c74431ef730cbc2912fe1814dd8d46c6515ce22b39c57e8f03c337aa152fd49a4e
typescript: ">=4.8.4 <5.8.0"
checksum: 10c0/f7d2fe9a2bd8cb3ae6fafe5e465882a6784b2acf81d43d194c579381b92651c2ffc0fca69d2a35eee119f539622752a0e9ec063aaec7576d5d2bfe68b441980d
languageName: node
linkType: hard

"@typescript-eslint/visitor-keys@npm:8.5.0":
version: 8.5.0
resolution: "@typescript-eslint/visitor-keys@npm:8.5.0"
"@typescript-eslint/visitor-keys@npm:8.19.1":
version: 8.19.1
resolution: "@typescript-eslint/visitor-keys@npm:8.19.1"
dependencies:
"@typescript-eslint/types": "npm:8.5.0"
eslint-visitor-keys: "npm:^3.4.3"
checksum: 10c0/8b9e81968ad36e8af18ac17b63c4e0764612451ca085676c939b723549052243f63577d2706bc2da48174f11bf47587ab47e6e0b7c5b28d9f3c1ef7b9aad322d
"@typescript-eslint/types": "npm:8.19.1"
eslint-visitor-keys: "npm:^4.2.0"
checksum: 10c0/117537450a099f51f3f0d39186f248ae370bdc1b7f6975dbdbffcfc89e6e1aa47c1870db790d4f778a48f2c1f6cd9c269b63867c12afaa424367c63dabee8fd0
languageName: node
linkType: hard

Expand Down Expand Up @@ -17062,6 +17058,13 @@ __metadata:
languageName: node
linkType: hard

"eslint-visitor-keys@npm:^4.2.0":
version: 4.2.0
resolution: "eslint-visitor-keys@npm:4.2.0"
checksum: 10c0/2ed81c663b147ca6f578312919483eb040295bbab759e5a371953456c636c5b49a559883e2677112453728d66293c0a4c90ab11cab3428cf02a0236d2e738269
languageName: node
linkType: hard

"eslint@npm:8.57.1":
version: 8.57.1
resolution: "eslint@npm:8.57.1"
Expand Down Expand Up @@ -26955,8 +26958,8 @@ __metadata:
"@types/jscodeshift": "npm:0.12.0"
"@types/ncp": "npm:2.0.8"
"@types/prompts": "npm:2.4.9"
"@typescript-eslint/eslint-plugin": "npm:8.5.0"
"@typescript-eslint/parser": "npm:8.5.0"
"@typescript-eslint/eslint-plugin": "npm:8.19.1"
"@typescript-eslint/parser": "npm:8.19.1"
"@yarnpkg/types": "npm:4.0.0"
all-contributors-cli: "npm:6.26.1"
babel-jest: "npm:^29.7.0"
Expand Down Expand Up @@ -28878,12 +28881,12 @@ __metadata:
languageName: node
linkType: hard

"ts-api-utils@npm:^1.3.0":
version: 1.3.0
resolution: "ts-api-utils@npm:1.3.0"
"ts-api-utils@npm:^2.0.0":
version: 2.0.0
resolution: "ts-api-utils@npm:2.0.0"
peerDependencies:
typescript: ">=4.2.0"
checksum: 10c0/f54a0ba9ed56ce66baea90a3fa087a484002e807f28a8ccb2d070c75e76bde64bd0f6dce98b3802834156306050871b67eec325cb4e918015a360a3f0868c77c
typescript: ">=4.8.4"
checksum: 10c0/6165e29a5b75bd0218e3cb0f9ee31aa893dbd819c2e46dbb086c841121eb0436ed47c2c18a20cb3463d74fd1fb5af62e2604ba5971cc48e5b38ebbdc56746dfc
languageName: node
linkType: hard

Expand Down
Loading