Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display group if indexer unavailable #143

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Conversation

ryanchristo
Copy link
Member

Closes: #134

This pull request updates how we handle the error from the graphql endpoint when fetching historical proposals. If the graphql endpoint is unavailable, group pages will load successfully without historical proposals and the error from the graphql request will be logged to the console rather than being thrown (preventing the page from being viewed without historical proposals).

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for regen-groups-ui ready!

Name Link
🔨 Latest commit 9874705
🔍 Latest deploy log https://app.netlify.com/sites/regen-groups-ui/deploys/64dba939d5796b00088cb43c
😎 Deploy Preview https://deploy-preview-143--regen-groups-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ryanchristo ryanchristo marked this pull request as ready for review August 15, 2023 16:36
@ryanchristo ryanchristo requested a review from a team August 15, 2023 16:36
Copy link
Contributor

@wgwz wgwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A tangential thought I have while looking at this code is that maybe we could open issue for integrating sentry as we have it for regen-web. I.e. In the try-catch block we have here now, we could also raise a sentry alert, which would give us notifications etc. and also sentry would capture any other unhandled exceptions as well

@ryanchristo
Copy link
Member Author

LGTM! A tangential thought I have while looking at this code is that maybe we could open issue for integrating sentry as we have it for regen-web. I.e. In the try-catch block we have here now, we could also raise a sentry alert, which would give us notifications etc. and also sentry would capture any other unhandled exceptions as well

Definitely worth considering. Opened #144 for tracking. 👍

@ryanchristo ryanchristo merged commit ad10414 into dev Aug 15, 2023
@ryanchristo ryanchristo deleted the ryan/134-indexer-error branch August 15, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to view group page when indexer is unavailable
2 participants