fix: hide credit class entry if no credit class #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@erikalogie you can check that we no longer display the credit class entry incorrectly here: https://deploy-preview-2214--regen-marketplace.netlify.app/ |
|
@flagrede looks good! |
|
Logging in with a credit class admin regen1df675r9vnf7pdedn4sf26svdsem3ugavgxmy46: http://redwood.regen.network:1317/regen/ecocredit/v1/classes-by-admin/regen1df675r9vnf7pdedn4sf26svdsem3ugavgxmy46, I'm now not seeing the credit classes tab/menu item at all:
It's still there on the public profile: https://deploy-preview-2214--regen-marketplace.netlify.app/profiles/regen1df675r9vnf7pdedn4sf26svdsem3ugavgxmy46/credit-classes |
blushi
reviewed
Nov 20, 2023
web-marketplace/src/components/organisms/RegistryLayout/RegistryLayout.Header.tsx
Outdated
Show resolved
Hide resolved
flagrede
force-pushed
the
fix-2205-credit-classes-dropdown
branch
from
a04491a to
c284e7e
Compare
blushi
reviewed
Nov 20, 2023
| } = useProfileItems({}); | ||
| const { activeAccount } = useAuth(); | ||
| const { wallet, isConnected, accountByAddr } = useWallet(); | ||
| } = useProfileItems({ address: wallet?.address }); |
There was a problem hiding this comment.
Suggested change
| } = useProfileItems({ address: wallet?.address }); | |
| } = useProfileItems({}); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2205
Hide credit class entry in the user dropdown menu if the user has no credit class.
The credit class item was displayed in the user menu because if the allowed list param is not activated on the current chain, we display it by default. See this hook for more info.
The tab was not displayed in the user profile because we also checked the number of credit classes created there. This PR adds the same check for the user menu entry.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...