feat: connect wallet to web2 account on action #2219

flagrede · 2023-11-21T15:59:48Z

Description

Closes: #2159

Prompt web2 user to connect a wallet for on-chain action

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

provided a link to the relevant issue or specification
provided instructions on how to test
reviewed "Files changed" and left comments if necessary
confirmed all CI checks have passed

How to test

https://deploy-preview-2219--regen-marketplace.netlify.app/

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

confirmed all author checklist items have been addressed
reviewed code correctness and readability
verified React components follow DRY principles
reviewed documentation is accurate
reviewed tests
manually tested (if applicable)

netlify · 2023-11-21T15:59:53Z

✅ Deploy Preview for regen-website ready!

Name	Link
🔨 Latest commit	`0e0cfda`
🔍 Latest deploy log	https://app.netlify.com/sites/regen-website/deploys/6565c26f3e973f0008cb4c96
😎 Deploy Preview	https://deploy-preview-2219--regen-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

flagrede · 2023-11-21T16:16:39Z

There seems to be an issue on the deploy preview with the google login. It might be best to test locally in the meantime.

blushi · 2023-11-22T10:02:01Z

There seems to be an issue on the deploy preview with the google login. It might be best to test locally in the meantime.

I've updated the env var in Heroku so it redirects to the deploy preview for logging in with google.

@erikalogie you can test this on https://deploy-preview-2219--regen-marketplace.netlify.app/
Login with google and then try to perform on chain actions like buy, take from/put in basket...

blushi · 2023-11-22T10:10:53Z

web-marketplace/src/pages/ProfileEdit/hooks/useConnectWalletToAccount.tsx

+
+  useEffect(() => {
+    if (shouldConnectAccount && !isConnectingWalletRef.current) {
+      connectWalletCallback();


I'm getting the 'prove ownership' popup multiple times now

erikalogie · 2023-11-22T12:44:41Z

There seems to be an issue on the deploy preview with the google login. It might be best to test locally in the meantime.

I've updated the env var in Heroku so it redirects to the deploy preview for logging in with google.

@erikalogie you can test this on https://deploy-preview-2219--regen-marketplace.netlify.app/ Login with google and then try to perform on chain actions like buy, take from/put in basket...

I can't log in with google, I've tried all my different accounts and it isn't working.

Screen.Recording.2023-11-22.at.8.41.55.AM.mov

blushi · 2023-11-22T14:11:53Z

There seems to be an issue on the deploy preview with the google login. It might be best to test locally in the meantime.

I've updated the env var in Heroku so it redirects to the deploy preview for logging in with google.
@erikalogie you can test this on https://deploy-preview-2219--regen-marketplace.netlify.app/ Login with google and then try to perform on chain actions like buy, take from/put in basket...

I can't log in with google, I've tried all my different accounts and it isn't working.

Screen.Recording.2023-11-22.at.8.41.55.AM.mov

Weird, still investigating. In the meantime, you should be able to log in with email/passcode now.

erikalogie · 2023-11-22T15:56:22Z

There seems to be an issue on the deploy preview with the google login. It might be best to test locally in the meantime.

I've updated the env var in Heroku so it redirects to the deploy preview for logging in with google.
@erikalogie you can test this on https://deploy-preview-2219--regen-marketplace.netlify.app/ Login with google and then try to perform on chain actions like buy, take from/put in basket...

I can't log in with google, I've tried all my different accounts and it isn't working.
Screen.Recording.2023-11-22.at.8.41.55.AM.mov

Weird, still investigating. In the meantime, you should be able to log in with email/passcode now.

Great yes it is working properly with email/passcode log in

erikalogie · 2023-11-22T15:58:23Z

I did notice this small typo (was my bad, it was in the comps) https://monosnap.com/file/Hi4bf1EQnLTsVF03Xnw5qg6UqurgG6

flagrede · 2023-11-27T10:06:40Z

@blushi I think you had several 'prove ownership' popups because you had an error (like address already used) but the error was not handled properly because of a change made in postData. I fixed that here d4d83cb, should be better.

flagrede · 2023-11-27T10:10:41Z

@blushi Also I noted that the google login on staging does not redirect to the good origin preview URL. The login works but you would have to come back manually to the good preview url.

blushi · 2023-11-27T10:19:01Z

@blushi Also I noted that the google login on staging does not redirect to the good origin preview URL. The login works but you would have to come back manually to the good preview url.

yeah this is because the app redirect URL is set to the deploy preview URL for #2221 right now. This is an env var in the server.

netlify · 2023-11-27T12:05:21Z

marie left a comment:

If I try to connect a wallet address (assuming I haven't connected yet, auto_connect_wallet is not set), then I don't even get the prove ownership popup, only the wallet address is set from Keplr.

Browser metadata

Path:      /profile/edit/settings
Browser:   Chrome 119.0.0.0 on Mac OS 10.15.7
Viewport:  912 x 782 @2x
Language:  fr-FR
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

flagrede · 2023-11-27T14:17:01Z

marie left a comment:

If I try to connect a wallet address (assuming I haven't connected yet, auto_connect_wallet is not set), then I don't even get the prove ownership popup, only the wallet address is set from Keplr.

Browser metadata
Open Deploy Preview · Mark as Resolved

This is not the same story. This story is about connecting an account if the user tries to perform an on-chain action (like buying credits). That said, we might have a regression on this part in the user profile settings.

blushi

tACK

flagrede requested a review from a team November 21, 2023 16:16

blushi reviewed Nov 22, 2023

View reviewed changes

blushi force-pushed the feat-2159-connect-keplr-wallet-account branch from 216e5c6 to a2b3403 Compare November 22, 2023 14:01

flagrede force-pushed the feat-2159-connect-keplr-wallet-account branch from a2b3403 to dc5b399 Compare November 27, 2023 09:23

blushi mentioned this pull request Nov 28, 2023

fix: rm wallet loaded state from profile edit loader #2223

Merged

10 tasks

flagrede and others added 6 commits November 28, 2023 11:35

feat: connect wallet to web2 account on action

d396b53

fix: import

7dc2a77

fix: modal title wording

0262d88

fix: do not trigger action whenever connect modal is closed

6110671

fix: error handling in useConnectWalletToAccount

4c66e24

fix: rm wallet loaded state from profile edit loader (#2223)

0e0cfda

flagrede force-pushed the feat-2159-connect-keplr-wallet-account branch from 7e760ab to 0e0cfda Compare November 28, 2023 10:35

flagrede requested a review from blushi November 28, 2023 10:49

blushi approved these changes Nov 29, 2023

View reviewed changes

blushi merged commit 06bffa7 into dev Nov 29, 2023
11 checks passed

blushi deleted the feat-2159-connect-keplr-wallet-account branch November 29, 2023 13:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: connect wallet to web2 account on action #2219

feat: connect wallet to web2 account on action #2219

flagrede commented Nov 21, 2023 •

edited

Loading

netlify bot commented Nov 21, 2023 •

edited

Loading

flagrede commented Nov 21, 2023 •

edited

Loading

blushi commented Nov 22, 2023

blushi Nov 22, 2023

erikalogie commented Nov 22, 2023

blushi commented Nov 22, 2023

erikalogie commented Nov 22, 2023

erikalogie commented Nov 22, 2023

flagrede commented Nov 27, 2023

flagrede commented Nov 27, 2023

blushi commented Nov 27, 2023 •

edited

Loading

netlify bot commented Nov 27, 2023

flagrede commented Nov 27, 2023

blushi left a comment

feat: connect wallet to web2 account on action #2219

feat: connect wallet to web2 account on action #2219

Conversation

flagrede commented Nov 21, 2023 • edited Loading

Description

Author Checklist

How to test

Reviewers Checklist

netlify bot commented Nov 21, 2023 • edited Loading

✅ Deploy Preview for regen-website ready!

flagrede commented Nov 21, 2023 • edited Loading

blushi commented Nov 22, 2023

blushi Nov 22, 2023

Choose a reason for hiding this comment

erikalogie commented Nov 22, 2023

blushi commented Nov 22, 2023

erikalogie commented Nov 22, 2023

erikalogie commented Nov 22, 2023

flagrede commented Nov 27, 2023

flagrede commented Nov 27, 2023

blushi commented Nov 27, 2023 • edited Loading

netlify bot commented Nov 27, 2023

flagrede commented Nov 27, 2023

blushi left a comment

Choose a reason for hiding this comment

flagrede commented Nov 21, 2023 •

edited

Loading

netlify bot commented Nov 21, 2023 •

edited

Loading

flagrede commented Nov 21, 2023 •

edited

Loading

blushi commented Nov 27, 2023 •

edited

Loading