fix: APP-410 save buy flow on last user interaction #2574
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@erikalogie see testing instructions |
|
LGTM |
r41ph
force-pushed
the
fix-APP-410-save-buy-flow-on-last-user-interaction
branch
from
fef3652 to
0b294da
Compare
There was a problem hiding this comment.
Two additional comments:
- We don't save values for the last step to local storage
- When using credit card, if the user leaves the page while being on the last step, when he comes back, we should go back to step 2 (Payment info) because we need the user to re-enter credit card info since this is something we can't save to local storage of course
| ...data, | ||
| creditsAmount: _creditsAvailable, | ||
| currencyAmount: _spendingCap, | ||
| sellOrders: orderedSellOrders, |
There was a problem hiding this comment.
why aren't we setting this to the same value as in setValue(SELL_ORDERS, ...) just above?
There was a problem hiding this comment.
Good you noticed this, thanks
| { | ||
| ...data, | ||
| creditsAmount: currentCreditsAmount, | ||
| currencyAmount: currencyAmount, |
| { | ||
| ...data, | ||
| creditsAmount: currentCreditsAmount, | ||
| currencyAmount: isNaN(value) ? 0 : value, |
| updateMultiStepData( | ||
| { | ||
| ...data, | ||
| currency, | ||
| paymentOption, | ||
| currencyAmount: 0, | ||
| }, | ||
| activeStep, | ||
| ); |
There was a problem hiding this comment.
why is this needed?
we update the currencyAmount but not the sell orders which depend on it, which could lead to inconsistent data in local storage
There was a problem hiding this comment.
I'm updating the multistep data here to keep it in sync with the input field, don't you think this needs to be done?
There was a problem hiding this comment.
I'm not sure since it seems like this will be updated anyway from handleCurrencyAmountChange with the correct values for corresponding sell orders and credits input
| name: form.watch('name'), | ||
| email: form.watch('email'), |
There was a problem hiding this comment.
I believe form.getValues https://react-hook-form.com/docs/useform/getvalues would be more appropriate in this case, since we don't need to subscribe to value changes in this function
Description
https://regennetwork.atlassian.net/browse/APP-410
Now when users interact with the forms the information should be stored in the localstorage automatically even when the next button hasn't been clicked yet, and therefore, on navigating away and back to the same page, users should be in the same step and see the same form data as before navigating away.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...