feat: APP-352 buying options filter #2575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
blushi
commented
Jan 9, 2025
Comment on lines
+113
to
+114
| enabled: | ||
| !isOffChainProject && !classId && !projectId && !!ecocreditClient, |
There was a problem hiding this comment.
unrelated to this task but just a small optimization I spotted: in case of using this on an offchain project page, we were running getProjectsQuery, which is not useful here, because in the case of an offchain projectId (= on chain project id) is not defined so enabled was true
blushi
commented
Jan 9, 2025
| @@ -10,6 +10,7 @@ import { client as sanityClient } from 'lib/clients/sanity'; | |||
| import { AnchoredProjectMetadataLD } from 'lib/db/types/json-ld'; | |||
There was a problem hiding this comment.
important changes to review in this file
|
@erikalogie @S4mmyb please see testing instructions above |
|
@blushi looks great, here is some feedback:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://regennetwork.atlassian.net/browse/APP-352
Also closes: APP-501
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
From https://deploy-preview-2575--regen-marketplace.netlify.app/projects/1:
Test the new buying options filters.
Selected buying options filters should impact the "credit class" filter options:
Selected credit classes should impact the "buying options" filter options:
Check that on prefinance projects page, there's only the "buying options" filter with "credit card" checked as the only option and disabled.
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...