-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bot scripts in recipe #93
Comments
Maybe we source a custom migrator? This will require:
Eg bot finds @scopatz would it be possible to xonsh source as a context manager? (to address 2) |
What do you mean exactly? Can you give an example usage? |
recipe provides its own ...
for feedstock in feedstocks:
with source 'bot.xsh': # if this doesn't exist do nothing
run(Version()) # This uses version from 'bot.xsh' if it exists else run on defaults |
We have discussed this out of bounds bit |
@beckermr is anything like this in plans? |
Likely not. We don't want to run untrusted code in the bot infrastructure. |
Thank you. I was thinking about this issue: #2821 (comment) . May be there is a way to add script that will get build number from version... One possible hack I was thinking is to create dummy setup.py, to get build numbers from versions, and later inject it into meta.yaml by using Another thing we were discussing with @oleksandr-pavlyk today is to create proxy github repo that calls for new versions and then if available does dummy release with versions that is then picked up by the bot. Original problem is that we have two repack repos like this: |
I don't recall this discussion exactly, but I'll say (maybe again) that the build number marks which build of a given version for a recipe. The build number should be independent of the version. Anything else is not supported by the bot directly. If you can make the recipe do it via some mechanism, then fine. However, I would recommend reconsidering your approach. |
In discussion with @scopatz
It might be nice to have a system where feedstocks can have a script which overrides the normal bot behavior for PRing. This would allow things with janky setups to be able to use the bot's bumping capabilities without having the bot need to deal with every corner case itself. We could also expand this to handle getting upstream versions if there are some recipes who's upstream is a bit off the beaten path
The text was updated successfully, but these errors were encountered: