Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some fixes for false-positive model validation test failures #3335

Merged
merged 18 commits into from
Jan 3, 2025

Conversation

beckermr
Copy link
Contributor

@beckermr beckermr commented Dec 7, 2024

Description:

This PR fixes some false-positive model validation errors. With this PR, there are 15 errors when I last ran the tests.

Checklist:

  • Pydantic model updated or no update needed

Cross-refs, links to issues, etc:

@beckermr
Copy link
Contributor Author

beckermr commented Dec 7, 2024

pre-commit.ci autofix

Copy link

codecov bot commented Dec 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.99%. Comparing base (91fb8d3) to head (640d8ef).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
conda_forge_tick/make_graph.py 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3335      +/-   ##
==========================================
- Coverage   77.04%   76.99%   -0.05%     
==========================================
  Files         132      132              
  Lines       14516    14525       +9     
==========================================
  Hits        11184    11184              
- Misses       3332     3341       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beckermr beckermr marked this pull request as ready for review January 3, 2025 18:11
@beckermr beckermr enabled auto-merge (squash) January 3, 2025 18:11
@beckermr
Copy link
Contributor Author

beckermr commented Jan 3, 2025

pre-commit.ci autofix

@beckermr beckermr merged commit 4b4039f into main Jan 3, 2025
5 checks passed
@beckermr beckermr deleted the fix-models branch January 3, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant