Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relock w/ conda-lock #3582

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

relock w/ conda-lock #3582

wants to merge 2 commits into from

Conversation

regro-cf-autotick-bot
Copy link
Collaborator

This pull request relocks the dependencies with conda-lock.

The following packages have been updated:

platform: osx-arm64
- rattler-build: 0.34.1 -> 0.35.1

platform: linux-64
- rattler-build: 0.34.1 -> 0.35.1

platform: osx-64
- rattler-build: 0.34.1 -> 0.35.1

@regro-cf-autotick-bot regro-cf-autotick-bot added the dependencies Pull requests that update a dependency file label Jan 17, 2025
@beckermr
Copy link
Contributor

@wolfv Can you look at this rattler-build error?

@wolfv
Copy link
Contributor

wolfv commented Jan 17, 2025

Hmm, the behavior of rattler-build changed because I thought the expectation would be to not automatically load adjacent variant config files if an explicit variant config is given.

So e.g. for the pytorch-cpu-feedstock we stop loading variants.yaml automatically, and based on the code only look at .ci_support/*.

@beckermr
Copy link
Contributor

Hmm, the behavior of rattler-build changed because I thought the expectation would be to not automatically load adjacent variant config files if an explicit variant config is given.

conda-build loads all of them and has a specific order for which ones take precedence over the others. I think folks will expect rattler-build to follow the same spec or a CEP specifying how this should work needs to be written. See this code comment: https://github.com/conda/conda-build/blob/main/conda_build/variants.py#L207

@wolfv
Copy link
Contributor

wolfv commented Jan 17, 2025

OK, I'll add behavior to load adjacent variants and layer additional variants on top.

I will not implement behavior to load variant files from magical other places :)

@beckermr
Copy link
Contributor

I will not implement behavior to load variant files from magical other places :)

Ummmm ok? The defacto conda standard is what is in conda-build unless we have a CEP for it. I suggest if you want new behavior that you write and submit a CEP for voting. We can't maintain a coherent ecosystem if individual authors pick and choose.

@wolfv
Copy link
Contributor

wolfv commented Jan 17, 2025

We just don't load variant config files from the user home dir etc. :)

@wolfv
Copy link
Contributor

wolfv commented Jan 17, 2025

Can we run this again with 0.35.2 or 0.35.3? Both should have the fix

@beckermr
Copy link
Contributor

/relock-conda

@beckermr
Copy link
Contributor

I am still seeing the same file opening error.

@beckermr
Copy link
Contributor

This is with 0.35.3

@wolfv
Copy link
Contributor

wolfv commented Jan 17, 2025

Will have to investigate tomorrow. Sorry

@beckermr beckermr disabled auto-merge January 17, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants