Add generate_random_salt.sh script #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stamepicmorg
requested review from
a team,
stamepicmorg,
s1lentq and
SergeyShorokhov
and removed request for
a team and
stamepicmorg
allows for automatic configuration of SteamIdHashSalt on Linux (or WSL) updated the readme to reflect this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in #1 and #4 , the addition of SteamIdHashSalt has confused some users.
To help users I added a script 'generate_random_salt.sh' to automatically generate a random 32-length hexadecimal string and write it to reunion.cfg.
It's also helpful for hlds container autoconfiguration scripts and the like.
Also changed the Readme to reflect this.
The script should be compatible with pretty much any distro out there as it requires tools that should exist in any of them: grep, wc, sed plus one of openssl / hexdump / xxd / tr.
The script checks for the existence of these tools and chooses the correct one or fails gracefully if it cannot find them.
The script is a good stopgap solution but further on it could be considered that if SteamIdHashSalt is left blank, ReUnion would automatically create a random salt and write it to reunion.cfg.
This is as simple as reading random bytes from /dev/urandom on Linux or using advapi32:SystemFunction036() on Windows (SystemFunction036 is supported by WinXP/Server2003 and up, so on earlier Windows it could still fall back to the original error message).