-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to lutaml-model #90
Draft
andrew2net
wants to merge
20
commits into
main
Choose a base branch
from
shale-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
44a457d
WIP create some model elements
andrew2net fe3f055
WIP create some model elements
andrew2net 5bf0ae8
WIP create some model elements
andrew2net f80f4ea
WIP create some model elements
andrew2net 95d2694
WIP create some model elements
andrew2net e35ed82
WIP create some model elements
andrew2net 6aa72ea
WIP create some model elements
andrew2net e03d0da
WIP create some model elements
andrew2net 20cb40d
WIP
andrew2net 77dd434
WIP
andrew2net 596f8e4
WIP
andrew2net e1ed1e1
WIP
andrew2net f48e54f
WIP
andrew2net c415182
WIP
andrew2net b8cce92
Merge branch 'main' into shale-integration
andrew2net 511cf82
WIP create Bibitem::Model classes
andrew2net 1635994
WIP
andrew2net b2dcf03
WIP update old YAML parser, we need to convert old files to new format
andrew2net 9b2008f
WIP
andrew2net 3c62ca0
WIP fixing tests
andrew2net File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,18 +7,25 @@ class Affiliation | |
# @return [Relaton::Bib::LocalizedString, nil] | ||
attr_accessor :name | ||
|
||
attr_writer :description | ||
|
||
# @return [Relaton::Bib::Organization] | ||
attr_accessor :organization | ||
|
||
# @param organization [Relaton::Bib::Organization, nil] | ||
# @param name [Relaton::Bib::LocalizedString, nil] | ||
# @param description [Array<Relaton::Bib::FormattedString>] | ||
# @param description [Array<Relaton::Bib::LocalizedString>] | ||
def initialize(organization: nil, name: nil, description: []) | ||
@name = name | ||
@organization = organization | ||
@description = description | ||
end | ||
|
||
def ==(other) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above. |
||
name == other.name && organization == other.organization && | ||
description == other.description | ||
end | ||
|
||
# @param opts [Hash] | ||
# @option opts [Nokogiri::XML::Builder] :builder XML builder | ||
# @option opts [String] :lang language | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lutaml::Model supports equivalence checks of attributes