make waiting for zap receipt a subscription since there might be dela…

…y in the zapper to publish the receipt
relaystr · Dec 22, 2024 · 3cb8452 · 3cb8452
1 parent d3c777c
commit 3cb8452
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/packages/ndk/example/zaps/zap.dart b/packages/ndk/example/zaps/zap.dart
@@ -15,7 +15,7 @@ void main() async {
   final ndk = Ndk(NdkConfig(
       eventVerifier: Bip340EventVerifier(),
       cache: MemCacheManager(),
-      logLevel: Logger.logLevels.info));
+      logLevel: Logger.logLevels.trace));
 
       // You need an NWC_URI env var or to replace with your NWC uri connection
   final nwcUri = Platform.environment['NWC_URI']!;

diff --git a/packages/ndk/lib/domain_layer/usecases/zaps/zaps.dart b/packages/ndk/lib/domain_layer/usecases/zaps/zaps.dart
@@ -78,7 +78,13 @@ class Zaps {
                 : Filter(kinds: [ZapReceipt.KIND], pTags: [pubKey!])
           ]);
           // TODO make timeout waiting for receipt parameterizable somehow
-          zapResponse.zapReceiptResponse!.stream.timeout(Duration(seconds: 30)).listen((event) {
+          final timeout = Timer(Duration(seconds: 30), () {
+            _requests.closeSubscription(
+                zapResponse.zapReceiptResponse!.requestId);
+            Logger.log.w("timed out waiting for zap receipt for invoice $invoice");
+          });
+
+          zapResponse.zapReceiptResponse!.stream.listen((event) {
             String? bolt11 = event.getFirstTag("bolt11");
             String? preimage = event.getFirstTag("preimage");
             if (bolt11!=null && bolt11 == invoice || preimage!=null && preimage==payResponse.preimage) {
@@ -89,13 +95,10 @@ class Zaps {
               } else {
                 Logger.log.w("Zap Receipt invalid: $receipt");
               }
+              timeout.cancel();
               _requests.closeSubscription(
                   zapResponse.zapReceiptResponse!.requestId);
             }
-          }).onError((error) {
-            _requests.closeSubscription(
-                zapResponse.zapReceiptResponse!.requestId);
-            Logger.log.w("timed out waiting for zap receipt for invoice $invoice");
           });
         } else {
           zapResponse.emitReceipt(null);