Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getPointer() to Dereferencable #304

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

sj-i
Copy link
Member

@sj-i sj-i commented Nov 12, 2023

Some internal structures like zend_object or zend_string uses C struct hack heavily. And the implementation of the memory profiler often needs to know the remote address and it's size of structures. So it's convenient if we can always get the original remote address and size used to dereference the objects.

Some internal structures like zend_object or zend_string uses C struct hack heavily. And the implementation of the memory profiler often needs to know the remote address and it's size of structures. So it's convenient if we can always get the original remote address and size used to dereference the objects.
@sj-i sj-i added this to the 0.9.0 milestone Nov 12, 2023
@sj-i sj-i added the enhancement New feature or request label Nov 12, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6843001597

  • 11 of 26 (42.31%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 79.168%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Lib/PhpInternals/Types/C/RawDouble.php 1 2 50.0%
src/Lib/PhpInternals/Types/C/RawInt32.php 1 2 50.0%
src/Lib/PhpInternals/Types/C/RawString.php 1 2 50.0%
src/Lib/PhpInternals/Types/Zend/Bucket.php 1 2 50.0%
src/Lib/PhpInternals/Types/Zend/ZendArray.php 1 2 50.0%
src/Lib/PhpInternals/Types/Zend/ZendClassEntry.php 1 2 50.0%
src/Lib/PhpInternals/Types/Zend/ZendExecuteData.php 1 2 50.0%
src/Lib/PhpInternals/Types/Zend/ZendExecutorGlobals.php 1 2 50.0%
src/Lib/PhpInternals/Types/Zend/ZendFunction.php 1 2 50.0%
src/Lib/PhpInternals/Types/Zend/ZendModuleEntry.php 1 2 50.0%
Totals Coverage Status
Change from base Build 6842785809: -0.4%
Covered Lines: 1904
Relevant Lines: 2405

💛 - Coveralls

@sj-i sj-i merged commit 31da803 into 0.9.x Nov 12, 2023
6 checks passed
@sj-i sj-i deleted the getpointer-to-dereferencable branch November 12, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants