Remove industry/fixed_shares #1941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbenke-pik
force-pushed
the
refactor
branch
3 times, most recently
from
0627776 to
f1fd1cc
Compare
fbenke-pik
commented
Jan 15, 2025
| @@ -505,28 +505,6 @@ vm_emiFgas.fx(ttot,all_regi,all_enty) = f_emiFgas(ttot,all_regi,"%c_SSP_forcing_ | |||
| display vm_emiFgas.L; | |||
|
|
|||
|
|
|||
| *** Bugfix. For some reason the model cannot reduce the production of district heating to 0 | |||
There was a problem hiding this comment.
@LaviniaBaumstark Can this really be removed, or does it have to be refactored?
There was a problem hiding this comment.
@robertpietzcker Can you comment on this? Can all of this deleted, or should we keep the fix for "feheb" only, or does this have to be refactored?
There was a problem hiding this comment.
if the runs work without I think it can be deleted. as the description said, it was never clear why this was needed - the model should have been able to stay at 0 anyway
fbenke-pik
commented
Jan 16, 2025
fbenke-pik
commented
Jan 16, 2025
fbenke-pik
commented
Jan 17, 2025
fbenke-pik
requested review from
robertpietzcker,
JakobBD and
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
robertpietzcker
approved these changes
Jan 23, 2025
LaviniaBaumstark
approved these changes
Jan 23, 2025
| @@ -501,6 +491,13 @@ all_enty "all types of quantities" | |||
| perm "Carbon permit" | |||
| peog "aggregated oil and gas, only relevant for calibration because IEA only provides aggregated data" | |||
| bfco2 "CO2 emission from blast furnace" | |||
|
|
|||
There was a problem hiding this comment.
nice, that you put them al togehter at teh and with the comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
fixed_shares.See also
Type of change
Checklist
remind2where it was neededFAIL 0in the output ofmake test)CHANGELOG.mdhas been updated correctlyFurther information
remove unused entries from IO mapping pik-piam/mrcommons#144
remove calcFeDemandTranpsort and Stationary from calcFeDemandIndustry pik-piam/mrremind#604
remove stationary from calcFeDemandIndustry pik-piam/mrindustry#16
remove variables / parameters after deletion of industry realization fixed_shares pik-piam/remind2#685
Test runs are here:
/p/tmp/benke/remind/output//p/tmp/benke/remind/compScen-fixed-shares-2025-01-22_11.16.31-H12.pdfComparison of results (what changes by this PR?):
11_aerosols)