Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a switch for normalising types at elaboration time #805

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kmemarian
Copy link
Collaborator

This switch replaces type aliases (e.g. size_t, uintptr_t) with their implementation-defined choice during the elaboration to Core.

This commit enables the switch in the frontend of CN.

This should address some issues from #678, #236, #272.

@cp526 for #678 CN now gives a "Missing resource for reading" error on variables with the alias type.

This switch replaces type aliases (e.g. size_t, uintptr_t) with
their implementation-defined choice during the elaboration to Core.

This commit enables the switch in the frontend of CN.
@kmemarian kmemarian requested a review from cp526 December 31, 2024 14:34
@kmemarian
Copy link
Collaborator Author

@cp526 the CI failures are the same

@cp526
Copy link
Collaborator

cp526 commented Jan 6, 2025

Thanks very much @kmemarian , that looks great!

The missing step to fix those CI failures is probably for CN to apply the same normalisation of C-types in certain places, so that where C-type equality is required (e.g. the resource inference), it uses equality post normalisation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants