Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implementation of news recurses of user app #27

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

renancorreadev
Copy link
Owner

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
    1

@renancorreadev renancorreadev merged commit 6bb70f3 into develop Nov 6, 2024
1 check passed
Copy link

github-actions bot commented Nov 6, 2024

Risk Level 3 - PointsDBStorageAdapter.ts

Consider using a more specific method than findOneBy in getPointOnDb function.


Risk Level 4 - deploy.ts

Avoid hardcoding file paths in updateEnvFile function, consider passing them as parameters.


Risk Level 4 - /home/runner/work/loyahub/loyahub/packages/loyahub-smart-contracts/scripts/deployPointsCore.ts

API key or secret detected in plain text: process.env.JSON_RPC_URL. Ensure sensitive information is not exposed in the code.


🔍🚫🔒


Powered by Code Review GPT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant