rename the AuthTokenStore* machinery to RecordReplayService* #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toshok
commented
Dec 13, 2023
| @@ -0,0 +1,20 @@ | |||
| module record_replay.mojom; | |||
|
|
|||
| // Provides access to the browser-side record/replay service. | |||
There was a problem hiding this comment.
This additional line is one of the two changes that are not strict file/symbol renaming.
toshok
commented
Dec 13, 2023
Comment on lines
-117
to
-118
| mojo::Remote<auth_token::mojom::RecordReplayAuthTokenStore> auth_token_store_; | ||
|
|
There was a problem hiding this comment.
and this file's change is the other that's not renaming. The window proxy creates a RecordReplayEventListener, which routes events through its LocalFrame, which then delegates to its LocalFrameMojoHandler to deal with all the mojo stuff.
kannanvijayan
approved these changes
Dec 14, 2023
toshok
added a commit
that referenced
this pull request
Jan 3, 2024
Squashed commit of the following:
commit 994bdc9bd36d870958e6bd8e213c6905a6038dca
Author: Chris Toshok <toshok@gmail.com>
Date: Wed Dec 13 12:52:12 2023 -0800
remove the include too
commit 3e82c721ce9bc805298538f6c1c3c56eb8a004b0
Author: Chris Toshok <toshok@gmail.com>
Date: Wed Dec 13 12:08:38 2023 -0800
the big renaming
commit bd81a6c7578e61771240a8fa7b3c7672973f9d68
Author: Chris Toshok <toshok@gmail.com>
Date: Wed Dec 13 10:08:04 2023 -0800
rename the member fields, and switch to checking if the observer receiver is already bound (saving us that weird extra auth_token_store_ check) in RecordReplayRegisterAuthTokenObserver)
commit 7f8369014d39183acc4efca9220dafcd51912f82
Author: Chris Toshok <toshok@gmail.com>
Date: Fri Dec 8 11:23:30 2023 -0800
plumb the rest of the devtools messages to the (increasingly misnamed) auth token store
kannanvijayan
pushed a commit
that referenced
this pull request
Jan 8, 2024
Squashed commit of the following:
commit 994bdc9bd36d870958e6bd8e213c6905a6038dca
Author: Chris Toshok <toshok@gmail.com>
Date: Wed Dec 13 12:52:12 2023 -0800
remove the include too
commit 3e82c721ce9bc805298538f6c1c3c56eb8a004b0
Author: Chris Toshok <toshok@gmail.com>
Date: Wed Dec 13 12:08:38 2023 -0800
the big renaming
commit bd81a6c7578e61771240a8fa7b3c7672973f9d68
Author: Chris Toshok <toshok@gmail.com>
Date: Wed Dec 13 10:08:04 2023 -0800
rename the member fields, and switch to checking if the observer receiver is already bound (saving us that weird extra auth_token_store_ check) in RecordReplayRegisterAuthTokenObserver)
commit 7f8369014d39183acc4efca9220dafcd51912f82
Author: Chris Toshok <toshok@gmail.com>
Date: Fri Dec 8 11:23:30 2023 -0800
plumb the rest of the devtools messages to the (increasingly misnamed) auth token store
toshok
force-pushed
the
toshok/more-devtools-plumbing
branch
from
bd81a6c to
6a5e46b
Compare
… already bound (saving us that weird extra check) in RecordReplayRegisterAuthTokenObserver)
toshok
force-pushed
the
toshok/rename-auth-token-store
branch
from
994bdc9 to
c8e1f35
Compare
|
big rebase party above - now that #1032 landed, rebase on current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1032.
#1032 fleshed out the rest of the interface between browser tabs and the auth token store, by adding several interface messages that are decidedly not about auth tokens. This PR renames the following:
RecordReplayAuthTokenStore->RecordReplayServiceRecordReplayAuthTokenStoreFactory->RecordReplayServiceFactoryRecordReplayAuthTokenStoreObserver->RecordReplayAuthTokenObserverAll files were renamed as well (from
auth_token*torecord_replay*.)