Add strict option to upload all (#304)

replayio · Jan 19, 2024 · 5b692ca · 5b692ca
1 parent 96ee8eb
commit 5b692ca
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/packages/replay/src/main.ts b/packages/replay/src/main.ts
@@ -31,6 +31,7 @@ import {
   RecordingEntry,
   SourceMapEntry,
   UploadAllOptions,
+  UploadOptions,
 } from "./types";
 import { add, sanitize, source as sourceMetadata, test as testMetadata } from "../metadata";
 import jsonata from "jsonata";
@@ -328,7 +329,7 @@ async function doUploadRecording(
   return recordingId;
 }
 
-async function uploadRecording(id: string, opts: Options = {}) {
+async function uploadRecording(id: string, opts: UploadOptions = {}) {
   const server = getServer(opts);
   const dir = getDirectory(opts);
   const recordings = readRecordings(dir);
@@ -391,7 +392,7 @@ async function processRecording(id: string, opts: Options = {}) {
   return succeeded ? recordingId : null;
 }
 
-async function uploadAllRecordings(opts: Options & UploadAllOptions = {}) {
+async function uploadAllRecordings(opts: UploadAllOptions = {}) {
   const server = getServer(opts);
   const dir = getDirectory(opts);
   const allRecordings = readRecordings(dir).filter(r => !uploadSkipReason(r));
@@ -429,7 +430,7 @@ async function uploadAllRecordings(opts: Options & UploadAllOptions = {}) {
   const recordingIds: (string | null)[] = await pMap(
     recordings,
     (r: RecordingEntry) =>
-      doUploadRecording(dir, server, r, opts.verbose, opts.apiKey, opts.agent, false),
+      doUploadRecording(dir, server, r, opts.verbose, opts.apiKey, opts.agent, false, opts.strict),
     { concurrency: batchSize, stopOnError: false }
   );
 

diff --git a/packages/replay/src/types.ts b/packages/replay/src/types.ts
@@ -22,11 +22,6 @@ export interface Options {
   apiKey?: string;
   verbose?: boolean;
   agent?: any;
-
-  /**
-   * Fail the recording upload if any part of the upload fails.
-   */
-  strict?: boolean;
 }
 
 export interface SourcemapUploadOptions {
@@ -64,7 +59,14 @@ export interface ListOptions extends FilterOptions {
   all?: boolean;
 }
 
-export interface UploadAllOptions extends FilterOptions {
+export interface UploadOptions extends Options {
+  /**
+   * Fail the recording upload if any part of the upload fails.
+   */
+  strict?: boolean;
+}
+
+export interface UploadAllOptions extends FilterOptions, UploadOptions {
   batchSize?: number;
   warn?: boolean;
 }