Add warning message when crash reports are skipped during upload

replayio · Nov 8, 2023 · 780b4b6 · 780b4b6
1 parent 7f6306b
commit 780b4b6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/packages/replay/src/main.test.ts b/packages/replay/src/main.test.ts
@@ -29,7 +29,7 @@ describe("filterRecordings", () => {
       },
     ];
 
-    const filtered = filterRecordings(recordings, r => r.id === "3");
+    const filtered = filterRecordings(recordings, r => r.id === "3", false);
     expect(filtered).toHaveLength(1);
   });
   it("inclues crash reports when includeCrashes is set", () => {

diff --git a/packages/replay/src/main.ts b/packages/replay/src/main.ts
@@ -552,6 +552,18 @@ async function uploadAllRecordings(opts: Options & UploadAllOptions = {}) {
   const allRecordings = readRecordings(dir).filter(r => !uploadSkipReason(r));
   const recordings = filterRecordings(allRecordings, opts.filter, opts.includeCrashes);
 
+  if (
+    allRecordings.some(r => r.status === "crashed") &&
+    !recordings.some(r => r.status === "crashed") &&
+    opts.filter &&
+    !opts.includeCrashes
+  ) {
+    maybeLog(
+      opts.verbose,
+      `\n⚠️ Warning: Some crash reports were created but will not be uploaded because of the provided filter. Add --include-crashes to upload crash reports.\n`
+    );
+  }
+
   if (recordings.length === 0) {
     if (opts.filter && allRecordings.length > 0) {
       maybeLog(opts.verbose, `No replays matched the provided filter`);