Inherit stdio in launch + make browsers optional for `update-br…

…owsers` (#273)
replayio · Nov 15, 2023 · 917cf21 · 917cf21
2 parents 0c6f165 + 323b86d
commit 917cf21
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/packages/replay/src/bin.ts b/packages/replay/src/bin.ts
@@ -109,7 +109,7 @@ commandWithGlobalOptions("rm-all")
 
 commandWithGlobalOptions("update-browsers")
   .description("Update browsers used in automation.")
-  .arguments("<browsers...>")
+  .arguments("[<browsers...>]")
   .action(commandUpdateBrowsers);
 
 commandWithGlobalOptions("upload-sourcemaps")

diff --git a/packages/replay/src/main.ts b/packages/replay/src/main.ts
@@ -832,8 +832,25 @@ async function launchBrowser(
   const proc = spawn(execPath, browserArgs[browserName], {
     detached: !attach,
     env: { ...process.env, RECORD_REPLAY_DIRECTORY: opts?.directory },
+    stdio: "inherit"
   });
-  proc.unref();
+  if (!attach) {
+    proc.unref();
+  }
+  else {
+    // Wait for the browser process to finish.
+    await new Promise<void>((resolve, reject) => {
+      proc.on("error", reject);
+      proc.on("exit", (code, signal) => {
+        if (code || signal) {
+          reject(new Error(`Process failed code=${code}, signal=${signal}`));
+        }
+        else {
+          resolve();
+        }
+      });
+  });
+  }
 
   return proc;
 }