Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options to replay launch #272

Conversation

ryanjduffy
Copy link
Contributor

replay-launch will now log before installing a browser and supports specifying a directory into which the browser will be installed and where recordings will be saved.

`replay-launch` will now log before installing a browser and supports
specifying a directory into which the browser will be installed and
where recordings will be saved.
@ryanjduffy ryanjduffy requested a review from hbenl November 8, 2023 19:09
Copy link

replay-io bot commented Nov 8, 2023

StatusComplete ↗︎
Commit55656b4
Results
2 Failed
  • cypress/e2e/adding-spec.ts
      AssertionError: Timed out retrying after 4000ms: Expected to find content: 'Sorry, something went wrong' but never did.
          at Context.eval (webpack:///./cypress/e2e/adding-spec.ts:99:49)
  • cypress/e2e/button-spec.ts
      CypressError: Timed out retrying after 4050ms: `cy.click()` failed because this element is detached from the DOM.
      `<button data-test-id="disappearingButton" data-reactid=".0.0">Disappe...</button>`
      Cypress requires elements be attached in the DOM to interact with them.
      The previous command that ran was:
        > `cy.get()`
      This DOM element likely became detached somewhere between the previous and current command.
      Common situations why this happens:
        - Your JS framework re-rendered asynchronously
        - Your app code reacted to an event firing and removed the element
      You typically need to re-query for the element or add 'guards' which delay Cypress from running new commands.
      https://on.cypress.io/element-has-detached-from-dom
          at $Cy.ensureAttached (http://localhost:8888/__cypress/runner/cypress_runner.js:147471:76)
          at runAllChecks (http://localhost:8888/__cypress/runner/cypress_runner.js:133346:12)
          at retryActionability (http://localhost:8888/__cypress/runner/cypress_runner.js:133426:16)
          at tryCatcher (http://localhost:8888/__cypress/runner/cypress_runner.js:11318:23)
          at Promise.attempt.Promise.try (http://localhost:8888/__cypress/runner/cypress_runner.js:8592:29)
          at whenStable (http://localhost:8888/__cypress/runner/cypress_runner.js:152665:65)
          at <unknown> (http://localhost:8888/__cypress/runner/cypress_runner.js:152095:14)
          at tryCatcher (http://localhost:8888/__cypress/runner/cypress_runner.js:11318:23)
          at Promise._settlePromiseFromHandler (http://localhost:8888/__cypress/runner/cypress_runner.js:9253:31)
          at Promise._settlePromise (http://localhost:8888/__cypress/runner/cypress_runner.js:9310:18)
          at Promise._settlePromise0 (http://localhost:8888/__cypress/runner/cypress_runner.js:9355:10)
          at Promise._settlePromises (http://localhost:8888/__cypress/runner/cypress_runner.js:9435:18)
          at Promise._fulfill (http://localhost:8888/__cypress/runner/cypress_runner.js:9379:18)
          at <unknown> (http://localhost:8888/__cypress/runner/cypress_runner.js:10993:46)
      From Your Spec Code:
          at Context.eval (webpack:///./cypress/e2e/button-spec.ts:3:48)
17 Passed

@ryanjduffy ryanjduffy merged commit ef19c49 into main Nov 9, 2023
3 of 4 checks passed
@ryanjduffy ryanjduffy deleted the ryan/scs-1504-replay-cli-launch-seems-idle-when-downloading-new-browser branch November 9, 2023 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants