Add replay record command to launch and record #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flake
|
jasonLaster
reviewed
Dec 2, 2023
| ...process.env, | ||
| RECORD_ALL_CONTENT: "1", |
There was a problem hiding this comment.
I think you still need RECORD_ALL_CONTENT for the record option, right?
There was a problem hiding this comment.
It moved up two lines
| @@ -830,15 +832,15 @@ async function launchBrowser( | |||
| }; | |||
|
|
|||
| const proc = spawn(execPath, browserArgs[browserName], { | |||
| detached: !attach, | |||
| detached: !opts?.attach, | |||
There was a problem hiding this comment.
@jazzdan added it so the CLI process wouldn't exit until the the browser exited. Not sure why (but not really relevant to this PR either)
| ) { | ||
| try { | ||
| debug("Options", opts); | ||
|
|
||
| const browser = fuzzyBrowserName(opts.browser) || "chromium"; | ||
| assertValidBrowserName(browser); | ||
|
|
||
| const attach = opts.attach || false; | ||
| await launchBrowser(browser, [url || "about:blank"], false, { ...opts, verbose: true }); |
There was a problem hiding this comment.
Correct me if I'm wrong but this is a breaking change. Do you know if users rely on this command and if we need to have any migrate path?
There was a problem hiding this comment.
It is a breaking change. I don't think anyone outside of us and QA is using it though.
jasonLaster
approved these changes
Dec 4, 2023
ryanjduffy
deleted the
ryan/scs-1629-support-interactive-recording-from-replay-launch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
replay recordcommand to launch and record and updatereplay launchto only launch the browser. Both now can be manually overridden by settingRECORD_ALL_CONTENTin the env.