Ignore replay-connect callback event #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
approved these changes
Dec 27, 2023
| @@ -54,11 +54,27 @@ let gPluginServer: WebSocket | undefined; | |||
| // user-facing | |||
| const COMMAND_IGNORE_LIST = ["log-restore", "within-restore", "end-logGroup"]; | |||
|
|
|||
| function handleReplayConnectResponse(v: unknown) { | |||
| if (v && typeof v === "object" && "port" in v && typeof v.port === "number") { | |||
There was a problem hiding this comment.
purely a nit, but something like this is a bit cleaner for me
if (typeof v?.port !== "number") {
cy.log("[replay.io] Received unexpected response when connecting to plugin");
return;
}
gServerPort = v.port;There was a problem hiding this comment.
It is cleaner but it doesn't pass typechecking since v is unknown so more narrowing is required.
packages/cypress/src/support.ts
Outdated
| function shouldIgnoreCommand(cmd: Cypress.EnqueuedCommand | Cypress.CommandQueue) { | ||
| if (isCommandQueue(cmd)) { | ||
| cmd = cmd.toJSON() as any as Cypress.EnqueuedCommand; | ||
| } | ||
|
|
||
| if ( |
There was a problem hiding this comment.
it'd help to have a comment here
ryanjduffy
deleted the
ryan/scs-1642-metabase-test-metadata-could-not-be-processed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The plugin is adding
thencommands from ourreplay-connectcallback to thebeforeAllsteps for each test. This wasn't currently visible to users because we aren't showingbeforeAllandafterAllyet but it was introducing some confusion in troubleshooting SCS-1642 because there were events in places we didn't expect them to be.Resolution
Suppress our
handleReplayConnectResponsehandler called bythenfrom being added to steps and from creating annotations.