Add a 'strict' flag to have a recording upload fail if any part of the upload fails. #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazzdan
approved these changes
Jan 18, 2024
| /** | ||
| * Fail the recording upload if any part of the upload fails. | ||
| */ | ||
| strict?: boolean; |
There was a problem hiding this comment.
Are there situations where we wouldn't want this behavior? I guess maybe people wouldn't appreciate their CI failing if the recording upload fails?
There was a problem hiding this comment.
I have no idea why you wouldn't want this behaviour, but this is public/in the wild, and so making this anything other than opt-in could break users downstream, thus I'm adding the flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.