Optimize event handlers for performance and filesize

replete · Sep 20, 2024 · fd84103 · fd84103
1 parent 8d42669
commit fd84103
Show file tree

Hide file tree

Showing 14 changed files with 72 additions and 71 deletions.
diff --git a/dist/biscuitman-legacy.js b/dist/biscuitman-legacy.js
@@ -704,8 +704,12 @@
 	          saveConsents(false);
 	      }
 	    };
+	    ui.onchange = function (e) {
+	      if (!e.target.dataset.s) return;
+	      e.target.parentElement.classList.toggle('checked', e.target.checked);
+	    };
 	    dialog = ui.querySelector('dialog');
-	    if (o.dialogPolyfill && !dialog.close || !dialog.showModal) loadDialogPolyfill(dialog);
+	    if (o.dialogPolyfill && !dialog.close) loadDialogPolyfill(dialog);
 	    dialog.onclose = function () {
 	      return dispatch('close');
 	    };
@@ -717,11 +721,6 @@
 	        return e.key === 'Escape' ? e.preventDefault() : null;
 	      };
 	    }
-	    ui.querySelectorAll('[data-s]').forEach(function (checkbox) {
-	      return checkbox.addEventListener('change', function (e) {
-	        checkbox.parentElement.classList.toggle('checked', e.target.checked);
-	      });
-	    });
 	    d.body.appendChild(ui);
 	    w.addEventListener('resize', updateBannerHeight);
 	  }

diff --git a/dist/biscuitman-legacy.min.js b/dist/biscuitman-legacy.min.js
diff --git a/dist/biscuitman-legacy.withcss.js b/dist/biscuitman-legacy.withcss.js
@@ -704,8 +704,12 @@
 	          saveConsents(false);
 	      }
 	    };
+	    ui.onchange = function (e) {
+	      if (!e.target.dataset.s) return;
+	      e.target.parentElement.classList.toggle('checked', e.target.checked);
+	    };
 	    dialog = ui.querySelector('dialog');
-	    if (o.dialogPolyfill && !dialog.close || !dialog.showModal) loadDialogPolyfill(dialog);
+	    if (o.dialogPolyfill && !dialog.close) loadDialogPolyfill(dialog);
 	    dialog.onclose = function () {
 	      return dispatch('close');
 	    };
@@ -717,11 +721,6 @@
 	        return e.key === 'Escape' ? e.preventDefault() : null;
 	      };
 	    }
-	    ui.querySelectorAll('[data-s]').forEach(function (checkbox) {
-	      return checkbox.addEventListener('change', function (e) {
-	        checkbox.parentElement.classList.toggle('checked', e.target.checked);
-	      });
-	    });
 	    d.body.appendChild(ui);
 	    w.addEventListener('resize', updateBannerHeight);
 	  }

diff --git a/dist/biscuitman-legacy.withcss.min.js b/dist/biscuitman-legacy.withcss.min.js
diff --git a/dist/biscuitman.js b/dist/biscuitman.js
@@ -107,16 +107,17 @@
                     saveConsents(false);
             }
         };
+        ui.onchange = (e)=>{
+            if (!e.target.dataset.s) return;
+            e.target.parentElement.classList.toggle('checked', e.target.checked);
+        };
         dialog = ui.querySelector('dialog');
-        if (o.dialogPolyfill && !dialog.close || !dialog.showModal) loadDialogPolyfill(dialog);
+        if (o.dialogPolyfill && !dialog.close) loadDialogPolyfill(dialog);
         dialog.onclose = ()=>dispatch('close');
         if (o.force) {
             dialog.oncancel = (e)=>e.preventDefault();
             dialog.onkeydown = (e)=>e.key === 'Escape' ? e.preventDefault() : null;
         }
-        ui.querySelectorAll('[data-s]').forEach((checkbox)=>checkbox.addEventListener('change', (e)=>{
-                checkbox.parentElement.classList.toggle('checked', e.target.checked);
-            }));
         d.body.appendChild(ui);
         w.addEventListener('resize', updateBannerHeight);
     }

diff --git a/dist/biscuitman.min.js b/dist/biscuitman.min.js
diff --git a/dist/biscuitman.withcss.js b/dist/biscuitman.withcss.js
@@ -107,16 +107,17 @@
                     saveConsents(false);
             }
         };
+        ui.onchange = (e)=>{
+            if (!e.target.dataset.s) return;
+            e.target.parentElement.classList.toggle('checked', e.target.checked);
+        };
         dialog = ui.querySelector('dialog');
-        if (o.dialogPolyfill && !dialog.close || !dialog.showModal) loadDialogPolyfill(dialog);
+        if (o.dialogPolyfill && !dialog.close) loadDialogPolyfill(dialog);
         dialog.onclose = ()=>dispatch('close');
         if (o.force) {
             dialog.oncancel = (e)=>e.preventDefault();
             dialog.onkeydown = (e)=>e.key === 'Escape' ? e.preventDefault() : null;
         }
-        ui.querySelectorAll('[data-s]').forEach((checkbox)=>checkbox.addEventListener('change', (e)=>{
-                checkbox.parentElement.classList.toggle('checked', e.target.checked);
-            }));
         d.body.appendChild(ui);
         w.addEventListener('resize', updateBannerHeight);
     }