Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esbuild overwrites #580

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

ShadiestGoat
Copy link
Contributor

This PR adds the ability for plugin & theme developers to overwrite the replugged esbuild config.
This is especially useful for when plugin developers need special configurations for their plugin to build - eg. adding font loaders for their css files.

The reason its a function rather than just extra config values is to allow developers to write their own plugins without removing the current required plugins.

The reason I chose to name the extra config file esbuild.extra.mjs is to avoid editors like vscode from using interpreting a esbuild.(m)js file as the thing to use for building (it causes a lang server crash)

This only affects plugin developers - this does not need a new replugged version release, just a new npm package.

Copy link
Member

@colin273 colin273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexisother lexisother merged commit f3aeca4 into replugged-org:main Dec 1, 2023
7 checks passed
@FedeIlLeone FedeIlLeone added enhancement New feature or request semver: patch Requires a patch semver version bump addon development Relates to developing addons, eg APIs or scripts labels Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon development Relates to developing addons, eg APIs or scripts enhancement New feature or request semver: patch Requires a patch semver version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants