Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed slash command api #604

Merged
merged 12 commits into from
Apr 7, 2024
Merged

fixed slash command api #604

merged 12 commits into from
Apr 7, 2024

Conversation

yofukashino
Copy link
Contributor

Fixed Slash commands not showing up
Embeded slash command's icon into replugged renderer itself

@netlify Netlify
Copy link

netlify bot commented Mar 12, 2024

❌ Deploy Preview for replugged-docs failed.

Name Link
🔨 Latest commit c887d82
🔍 Latest deploy log https://app.netlify.com/sites/replugged-docs/deploys/65f0ea9c369ef50008de62fc

12944qwerty
12944qwerty approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@12944qwerty 12944qwerty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and worked. See if you can type some of the unknown types to something more specific though.

@yofukashino
Copy link
Contributor Author

LGTM and worked. See if you can type some of the unknown types to something more specific though.

they aren't being used anywhere so I didn't but sure

@FedeIlLeone FedeIlLeone mentioned this pull request Apr 3, 2024
Merged
@FedeIlLeone FedeIlLeone added bug Something isn't working semver: patch Requires a patch semver version bump labels Apr 7, 2024
FedeIlLeone
FedeIlLeone requested changes Apr 7, 2024
View reviewed changes
Copy link
Member

@FedeIlLeone FedeIlLeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this

src/renderer/coremods/commands/index.ts Outdated Show resolved Hide resolved
@yofukashino yofukashino requested a review from FedeIlLeone April 7, 2024 19:42
@yofukashino yofukashino requested a review from FedeIlLeone April 7, 2024 20:03
@FedeIlLeone FedeIlLeone merged commit e81b190 into replugged-org:main Apr 7, 2024
8 checks passed
@yofukashino yofukashino deleted the applicationcommandapi-fix branch April 9, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@12944qwerty 12944qwerty 12944qwerty approved these changes

@FedeIlLeone FedeIlLeone FedeIlLeone approved these changes

Assignees
No one assigned
Labels
bug Something isn't working semver: patch Requires a patch semver version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yofukashino @FedeIlLeone @12944qwerty