Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies updates #630

Merged
merged 6 commits into from
Jul 6, 2024
Merged

Dependencies updates #630

merged 6 commits into from
Jul 6, 2024

Conversation

FedeIlLeone
Copy link
Member

@FedeIlLeone FedeIlLeone added the dependencies Pull requests that update a dependency file label Jun 19, 2024
colin273
colin273 reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@colin273 colin273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just not sure about the switch from the DefinitelyTyped highlightjs package to the full highlight.js module.

src/renderer/modules/common/hljs.ts Show resolved Hide resolved
@FedeIlLeone FedeIlLeone merged commit 914e2e0 into main Jul 6, 2024
14 checks passed
@FedeIlLeone FedeIlLeone deleted the dependencies-updates branch July 6, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin273 colin273 colin273 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FedeIlLeone @colin273