Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlexW-578's mods #160

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

Krzeszny
Copy link
Contributor

@Krzeszny Krzeszny commented Jan 18, 2025

Add AlexW-578 and their 3 mods

  • The mod id matches the harmony id if used by the mod and starts with the same id as your author folder
  • All used links are valid
  • Your ResoniteMod.Version must match the version being added in the manifest and follow Semantic Versioning
  • Your AssemblyVersion should match the mod version
  • You have included an accurate sha256 hash for each artifact
  • Do not remove old mods. Instead, use the deprecated flag
  • Follow the Resonite Policies and Guidelines and Mod Submission Guidelines

Added AlexW-578's author.json and their 3 mods
@XDelta XDelta added the Community PR Manifest additon made for somone else's mod(s) label Jan 18, 2025
@XDelta
Copy link
Member

XDelta commented Jan 21, 2025

Some minor inconsistency with 'co.uk.alexw-578' vs 'co.uk.AlexW-578'.
The folder for these and 'co.uk.alexw-578.CustomProtofluxBrowser' use lowercase, the other two mods use uppercasing.

@XDelta
Copy link
Member

XDelta commented Jan 23, 2025

Their mods seem to mostly use co.uk.AlexW-578 so I'd say to update the folder to that casing.

@Krzeszny
Copy link
Contributor Author

Alright, and I'll decapitalize the ID's because the source code has them without capitalization

@Krzeszny
Copy link
Contributor Author

Krzeszny commented Jan 23, 2025

Nevermind, the Harmony ID's are capitalized in all mods but CustomProtofluxBrowser and the manifest matches them. Alright, I think we're done here.

@Krzeszny
Copy link
Contributor Author

Still learning GitHub, bear with me. Should I squash these 9 commits?

@AlexW-578
Copy link

Their mods seem to mostly use co.uk.AlexW-578 so I'd say to update the folder to that casing.

Just updated the CustomProtofluxBrowser mod to be consistant to my other mods.
All mods now use co.uk.AlexW-578.

Can make another release if this needs to be also reflected within the dll file.

@XDelta
Copy link
Member

XDelta commented Jan 25, 2025

@Krzeszny don't worry about extra commits, they are squashed when merged. @AlexW-578 if you want to do so now, it can be added onto this PR, otherwise probably okay for a future release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community PR Manifest additon made for somone else's mod(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants