Many associations perform read repair on dead links when the association proxy is accessed. #302
Conversation
…d failing test as pending
…t since keys is not always accurate and includes dead links
…rt custom association names
…er from the class name
|
Is all the modification of the Gemfile necessary? What's wrong with the gemspec directive? |
| @@ -1,4 +1,4 @@ | |||
| # `ripple`: Riak Document Models [](http://travis-ci.org/basho/ripple) | |||
| # `ripple`: Riak Document Models [](http://travis-ci.org/validas/ripple) | |||
There was a problem hiding this comment.
Please revert/remove this change.
There was a problem hiding this comment.
Not problem. Would like to modify this in a way that it recognizes the repo so forks can still leverage the travis badge.
There was a problem hiding this comment.
A little JS might do the trick? Something we could push off to the Travis CI guys, maybe.
There was a problem hiding this comment.
Hopefully, going to tinker with it now. I can't believe this is the first repo that would benefit from this.
|
@seancribbs initially had problems with the gem spec and thought I had reverted it back with a follow up commit. |
| @@ -16,8 +16,8 @@ Gem::Specification.new do |gem| | |||
| gem.add_development_dependency 'rake' | |||
| gem.add_development_dependency 'ammeter', '~>0.2.2' | |||
| gem.add_dependency "riak-client", "~> 1.0.0" | |||
| gem.add_dependency "activesupport", [">= 3.0.0", "< 3.3.0"] | |||
| gem.add_dependency "activemodel", [">= 3.0.0", "< 3.3.0"] | |||
| gem.add_dependency "activesupport", ">= 3.0.0" | |||
There was a problem hiding this comment.
It is not clear whether Rails 4 will be supportable with the current code. Please revert this.
|
@seancribbs Reverted the travis badge for now. Looks like it will require effort from the Travis guys to make it work. |
This pull requests resolves Ripple issue #301
The read repair occurs when the association proxy is accessed (#find_target) and only cleans up dead links for that association. See specs for more detail on behavior.