-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub integration #5
base: main
Are you sure you want to change the base?
Conversation
Already have the sync functionality built but the setup UI looks a little "clunky", due to the added fields, and I would like to address that prior to submitting the PR for review. |
Hi, that's very nice work! Didn't got notified of the PR but will have a look in the evening! If I can support you somehow just let me know and I'll try to find some time :) |
Sounds great! Sorry, I kept it as a draft PR because I wanted to cleanup the Setup UI. If you want me to submit it as an actual request regardless let me know. |
…ted the providerselector component.
@riedeljan I made a few extra changes, and separated out the logic some more. Please have a look and if any changes need to be made feel free to let me know! |
Thank you so much, the changes look good to me so far! They go straight in the direction I wanted to refactor the code anyway - will review later! (: Really busy rn but love them! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I still didn't manage to proper test the additions but at least had the time to review the code changes. Weeks are way too busy rn. Let me know what you think! :) I'm confident we can finish this by the end of the weekend
350a911
to
e1fd661
Compare
All changes that were requested have since been implemented as of e1fd661 |
Thank you! The setup still looks broken which probably comes from the way the nested components are being loaded. I had a look but need to spend some more time with them and think through whether the nesting and code separation could be optimized. Still a good approach so far! 👌🏻 |
Any updates from that review? @riedeljan |
Current work in progress.
Adding Github sync support.