-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unix domain socket support #511
Conversation
Hmm, given that the unix domain sockets require at least java 16 (https://openjdk.org/jeps/380), should I update the pipeline to run the tests using java 17? I think (but i'm not sure) that this won't have any impact in runtime for the users that don't use the |
Thanks for the patch. I'd like to be sure that Jetty works over TCP for older versions of the JVM. Can you wrap the failing test in a conditional that checks the JVM version? Then we can potentially check with both. |
3f0357c
to
79e26ec
Compare
Done! Please run the tests again |
It looks good. Can you ensure that the lines in this patch are 80 characters or under? |
79e26ec
to
3fff1d8
Compare
Fixed a slightly longer def line in the test file, everything else is below 80 chars except from the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from a small typo in the docstring, this looks ready to merge. Apologies for taking a while to review this.
Signed-off-by: Loukas Agorgianitis <loukas@agorgianitis.com>
3fff1d8
to
df46973
Compare
Thanks for the patch! |
Similar to PR #478, although this now uses the new Unix Domain Socket Support in Jetty through
jetty-unixdomain-server
https://webtide.com/unixdomain-support-in-jetty/
Usage of the new APIs is documented here:
https://jetty.org/docs/jetty/11/programming-guide/server/http.html#connector
https://jetty.org/docs/jetty/11/programming-guide/client/http.html#transport-unix-domain