fix(typography-warning): [typography] warning when typography is not …

…existed
ringcentral · Jul 13, 2023 · 35291e5 · 35291e5
1 parent d0dc554
commit 35291e5
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/juno-core/src/foundation/styles/typography.ts b/packages/juno-core/src/foundation/styles/typography.ts
@@ -1,6 +1,7 @@
 import { css } from '../styled-components';
 import { RcThemeProps } from '../theme/theme.type';
 import { RcTypographyKeys } from '../theme/typography.type';
+import { logInDev } from '../utils';
 
 /**
  * get typography key value with token
@@ -17,7 +18,16 @@ function typographyProp(name: RcTypographyKeys, key: string) {
   return ({ theme }: RcThemeProps) => {
     const themeOfTypography = theme.typography[name];
     if (typeof themeOfTypography !== 'object') {
-      throw new Error(`Unexpected typography name: ${name}`);
+      if (process.env.NODE_ENV !== 'production') {
+        throw new Error(`Unexpected typography name: ${name}`);
+      } else {
+        logInDev({
+          message: `Unexpected typography name: ${name}`,
+          component: 'typographyProp',
+          level: 'warn',
+        });
+        return undefined;
+      }
     }
     return themeOfTypography[key];
   };

diff --git a/sync-github.json b/sync-github.json
@@ -1,3 +1,3 @@
 {
-  "latestCommitSHA": "e8ab96f9423498e6138559bebf947058973754aa"
+  "latestCommitSHA": "67e2f0e9b0ddeb1fe1f09327d3b32011acfa5051"
 }