Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#479 Support computation of initials config by adding initialsConfig method #485

Merged
merged 16 commits into from
Feb 22, 2023
Merged

#479 Support computation of initials config by adding initialsConfig method #485

merged 16 commits into from
Feb 22, 2023

Conversation

NFSS10
Copy link
Contributor

@NFSS10 NFSS10 commented Feb 21, 2023

- -
Issue #479
Dependencies --
Decisions - Add initialsConfig() method which runs the appy profiles logic locally. It's a implementation that matches the one done here: https://github.com/ripe-tech/ripe-compose/blob/40436c5207b01fdff100e6d2425018feb453c731/src/ripe_compose/util/configurator.py#L2213. The reason it's done is to support a way to compute the initials with the profiles applicated without having to do a remote call
- Add initialsConfig() tests

@NFSS10 NFSS10 added enhancement New feature or request unit-testing Issue requires creation of unit tests labels Feb 21, 2023
@NFSS10 NFSS10 self-assigned this Feb 21, 2023
@NFSS10 NFSS10 changed the title #479 Compute initials config locally #479 Support computation of initials config by adding initialsConfig method Feb 21, 2023
@NFSS10 NFSS10 requested a review from 3rdvision February 21, 2023 16:33
@NFSS10 NFSS10 assigned 3rdvision and unassigned NFSS10 Feb 21, 2023
3rdvision
3rdvision reviewed Feb 21, 2023
View reviewed changes
Copy link
Contributor

@3rdvision 3rdvision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvements as previously discussed.

src/js/base/config.js Show resolved Hide resolved
test/js/base/config.js Show resolved Hide resolved
test/js/base/config.js Show resolved Hide resolved
src/js/base/config.js Show resolved Hide resolved
@NFSS10
Copy link
Contributor Author

NFSS10 commented Feb 21, 2023

Linking discussion thread: https://platforme.slack.com/archives/C04PEFAK4BW/p1676996739770149

@NFSS10 NFSS10 assigned NFSS10 and unassigned 3rdvision Feb 22, 2023
@NFSS10 NFSS10 requested a review from 3rdvision February 22, 2023 11:58
@NFSS10 NFSS10 assigned 3rdvision and unassigned NFSS10 Feb 22, 2023
3rdvision
3rdvision reviewed Feb 22, 2023
View reviewed changes
src/js/base/config.js Outdated Show resolved Hide resolved
test/js/base/config.js Show resolved Hide resolved
@3rdvision 3rdvision assigned NFSS10 and unassigned 3rdvision Feb 22, 2023
@NFSS10 @3rdvision
docs: update initialsConfig() documentation
4bc7cf7 
Co-authored-by: Daniel Azevedo <kazgru@gmail.com>
@NFSS10 NFSS10 requested a review from 3rdvision February 22, 2023 12:18
@NFSS10 NFSS10 assigned 3rdvision and unassigned NFSS10 Feb 22, 2023
@3rdvision 3rdvision assigned NFSS10 and unassigned 3rdvision Feb 22, 2023
@NFSS10 NFSS10 merged commit e1d71b6 into master Feb 22, 2023
@NFSS10 NFSS10 deleted the ns/479-initials_config_local branch February 22, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3rdvision 3rdvision 3rdvision approved these changes

Assignees

@NFSS10 NFSS10

Labels
enhancement New feature or request unit-testing Issue requires creation of unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NFSS10 @3rdvision