-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wording and formatting of x0 special cases #1770
Conversation
Thanks for this, those semicolons somehow went missing. Can I suggest that you also change the "only valid" to "valid only", as it's grammatically an improvement. |
How about normalizing these "not equal" signs? Some are UTF-8, some are HTML entities and some are latexmath. I think UTF-8 would be best. |
I think UTF-8 would work. Perhaps add attributes to the header docs for UTF-8 replacements, such as:
Then replace in the asciidoc files with attribute references such as {ge} |
What do you mean by "header docs" ? Why use attribute references if we can (and already do) directly use Unicode characters? Especially for ASCII characters such as |
Asciidoc requires header docs, for the ISA manuals, they are riscv-unprivileged.adoc and riscv-privileged.adoc. At the beginning of each is a set of attributes that asciidoctor requires to build the full documents. Adding attributes for unicode would but down on a few keystrokes for extension authors. |
I see, there's no |
When merging, please select my Samsung email. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The title of this PR does not reflect what it actually does. It makes several wording changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much improved, thank you.
Restore semicolons removed accidentally in aaad788