Skip to content

Commit

Permalink
Update libpokemegb git submodule to fix bug
Browse files Browse the repository at this point in the history
Bug was reported by /u/imranFZakhaev on reddit:

When adding a pokémon to a save with a full party, the behaviour is
completely broken.

Not only did we add a pokémon to every box, but it also would be a
completely different one or even crash the game when trying to access
the box.

Fixes:

- Stop after adding a pokemon to a box. Don't add it to all.
- In commit 77d5d15 I added a ::setPokemon function and reworked the
  Gen1Box::add() function to use it. That's where it went wrong:

  in the add() function, we would modify the number_of_pokemon counter
  of the box, but not manipulate the species list and write it.
  Then in the setPokemon() function, we would read the box metadata and
  correct it because the number did not match the species list. This is
  what went wrong.

  To fix it, I just had to modify the species list in the add() function
  as well again.
  • Loading branch information
risingPhil committed Jul 26, 2024
1 parent 55cf13d commit 39d7c31
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libpokemegb

0 comments on commit 39d7c31

Please sign in to comment.