Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(udf): bump arrow-udf-wasm to 0.4.1 to fix rust udf compile target #20252

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Jan 22, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

arrow-udf-wasm 0.4.1 changed the wasi target from wasm32-wasi to wasm32-wasip1 following the upstream rustc change.

According to the notice:

Starting Rust 1.78 (May 2nd, 2024), users of WASI 0.1 are encouraged to begin migrating to the new wasm32-wasip1 target before the existing wasm32-wasi target is removed in Rust 1.84 (January 5th, 2025).

the old target name is officially deprecated in latest version.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

Copy link
Member Author

stdrc commented Jan 22, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@stdrc stdrc changed the title bump arrow-udf-wasm to 0.4.1 to fix rust udf compile target fix(udf): bump arrow-udf-wasm to 0.4.1 to fix rust udf compile target Jan 22, 2025
@stdrc stdrc marked this pull request as ready for review January 22, 2025 03:16
@stdrc stdrc requested a review from a team as a code owner January 22, 2025 03:16
@stdrc stdrc requested a review from xxchan January 22, 2025 03:16
@stdrc stdrc closed this Jan 22, 2025
@stdrc stdrc reopened this Jan 22, 2025
Signed-off-by: Richard Chien <stdrc@outlook.com>
@stdrc stdrc force-pushed the rc/bump-arrow-udf-wasm branch from 1adc52f to 7c0c3c8 Compare January 22, 2025 03:21
Copy link

gru-agent bot commented Jan 22, 2025

This pull request has been modified. If you want me to regenerate unit test for any of the files related, please find the file in "Files Changed" tab and add a comment @gru-agent. (The github "Comment on this file" feature is in the upper right corner of each file in "Files Changed" tab.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants