Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Beat Saber 1.37.0 #68

Merged
merged 26 commits into from
Jul 6, 2024
Merged

Conversation

nicoco007
Copy link
Contributor

At least 2 things are still broken:

  • SongCore progress bar throws an exception on startup
  • Pack list doesn't display properly and overlaps other buttons

@nicoco007 nicoco007 force-pushed the beat-saber-1.37.0 branch from 091af2d to ee04928 Compare June 11, 2024 23:36
@Meivyn Meivyn force-pushed the beat-saber-1.37.0 branch from e3ee48c to 37dbd1e Compare June 12, 2024 01:52
@Meivyn Meivyn force-pushed the beat-saber-1.37.0 branch from 6351cbc to 1ceb86b Compare June 12, 2024 01:56
@Meivyn Meivyn force-pushed the beat-saber-1.37.0 branch 2 times, most recently from edee9fc to 63a43b9 Compare June 17, 2024 07:34
Co-authored-by: Metalit <48568911+Metalit@users.noreply.github.com>
@Meivyn Meivyn force-pushed the beat-saber-1.37.0 branch from 63a43b9 to 4f9fac9 Compare June 17, 2024 08:24
@Meivyn Meivyn force-pushed the beat-saber-1.37.0 branch from d7d25ba to 54f345d Compare June 19, 2024 04:44
@Meivyn Meivyn force-pushed the beat-saber-1.37.0 branch from ce127f0 to a0af827 Compare July 5, 2024 23:49
@Meivyn Meivyn merged commit f597363 into rithik-b:master Jul 6, 2024
@ibillingsley
Copy link

ibillingsley commented Jul 11, 2024

I think there is a bug with removing songs from a playlist. It kept removing a different map than the one I had selected.

@ibillingsley
Copy link

ibillingsley commented Jul 12, 2024

I think I figured out the issue, but I'm not sure if it's a bug in PlaylistManager or BetterSongList.

If I sort the playlist by "Default" it correctly removes the selected map. But if I am using a different sort, it is removing the map at the selected index as if it were sorted by the default playlist order.

@Meivyn
Copy link
Collaborator

Meivyn commented Jul 12, 2024

Thank you for reporting, fixed in f6a1120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants